New issue
Advanced search Search tips

Issue 922852 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Disable copying of PpdProvider QueueEntry objects

Project Member Reported by luum@google.com, Jan 17 (6 days ago)

Issue description

Currently copying is allowed for these objects, but it should be disabled since they all carry base::OnceCallbacks.
 

Comment 1 by osh...@chromium.org, Jan 18 (4 days ago)

Components: Internals>Printing

Comment 2 by thestig@chromium.org, Jan 18 (4 days ago)

Components: -Internals>Printing Internals>Printing>CUPS
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 19 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac4281c7fe3b67e707ed50e03c792efcd720822c

commit ac4281c7fe3b67e707ed50e03c792efcd720822c
Author: Luum Habtemariam <luum@chromium.org>
Date: Sat Jan 19 01:35:03 2019

Disallow copy/assign for PpdProviderQueueEntry's

These QueueEntry's hold base::OnceCallback's so they can't be
copied/assigned; structs now reflect that.

Bug: chromium:922852
Test: PpdProvider tests still pass
Change-Id: I01ebd72df0a441043951b4b77bf9f3b40f686599
Reviewed-on: https://chromium-review.googlesource.com/c/1417992
Auto-Submit: Luum Habtemariam <luum@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624403}
[modify] https://crrev.com/ac4281c7fe3b67e707ed50e03c792efcd720822c/chromeos/printing/ppd_provider.cc

Sign in to add a comment