New issue
Advanced search Search tips

Issue 922842 link

Starred by 1 user
Status: Fixed
Owner:
carai...@chromium.org
Closed: Jan 18
Cc:
ksakamoto@google.com
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----

Blocking:
issue 879208



Sign in to add a comment

cronet_unittests failing on chromium.memory/Linux MSan Tests

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jan 17 (6 days ago) 
Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of ksakamoto@google.com

cronet_unittests failing on chromium.memory/Linux MSan Tests

Builders failed on: 
- Linux MSan Tests: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20MSan%20Tests

CronetStructTest.TestCronet_DateTime fails because it copies an uninitialized value.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 17 (6 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb3f19cdcdf1a1787e727f2d1675facdce88f243

commit fb3f19cdcdf1a1787e727f2d1675facdce88f243
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Thu Jan 17 01:55:12 2019

Disable CronetStructTest.TestCronet_DateTime on MSAN

TBR=caraitto@chromium.org,pauljensen@chromium.org,mef@chromium.org

No-Try: true
Bug:  922842 
Change-Id: I483fe6cfc7a8fbb77f53b15e6de898e6d1c469ce
Reviewed-on: https://chromium-review.googlesource.com/c/1415053
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623508}
[modify] https://crrev.com/fb3f19cdcdf1a1787e727f2d1675facdce88f243/components/cronet/native/generated/cronet.idl_impl_struct_unittest.cc

Comment 2 by ksakamoto@chromium.org, Jan 17 (6 days ago)

Blocking: 879208
Labels: -Sheriff-Chromium
Owner: carai...@chromium.org
Status: Assigned (was: Available)
Assigning caraitto@ for follow ups.

Comment 3 by mef@chromium.org, Jan 17 (5 days ago) 

Good catch. We should set default value to DateTime.value in cronet.idl.
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 17 (5 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b95baa036400de1918372682d0343c7204fbee23

commit b95baa036400de1918372682d0343c7204fbee23
Author: Caleb Raitto <caraitto@chromium.org>
Date: Thu Jan 17 23:10:06 2019

[Cronet] Default DateTime.value to 0 to fix MSAN issue.

Bug:  922842 ,879208
Change-Id: I44a70473504c9e32f4bc45520f5c2ef213388787
Reviewed-on: https://chromium-review.googlesource.com/c/1418877
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623893}
[modify] https://crrev.com/b95baa036400de1918372682d0343c7204fbee23/components/cronet/native/cronet.idl
[modify] https://crrev.com/b95baa036400de1918372682d0343c7204fbee23/components/cronet/native/generated/cronet.idl_impl_struct.h
[modify] https://crrev.com/b95baa036400de1918372682d0343c7204fbee23/components/cronet/native/generated/cronet.idl_impl_struct_unittest.cc

Comment 5 by carai...@chromium.org, Jan 18 (5 days ago)

Status: Fixed (was: Assigned)
►

Sign in to add a comment