New issue
Advanced search Search tips

Issue 922832 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Tast (and Autotest?) should use HistogramSet to report perf values

Project Member Reported by derat@chromium.org, Jan 17 (6 days ago)

Issue description

In an email thread ("Allowed characters in chromeperf data?"), benjhayden@ wrote this (on the topic of allowable characters in unit tests in perf data reported by Tast tests):

"I assume you're using the deprecated /add_points endpoint that accepts chartjson.
Please schedule migration to uploading HistogramSet JSON to /add_histograms using OAuth.
If you have any questions, please don't hesitate to ask or schedule a call.
If necessary, you can use chartjson2histograms, though I recommend planning to eventually modify tests to produce Histograms directly. We plan to have an implementation of Histograms for C++ and golang this year.
Units in chartjson can include slashes ("chars/s" has been used), but units in Histograms are more structured so that the frontend can format scalars more intelligently. Only these units are supported for now, including Hz and bytesPerSecond. If there's a compelling use case, then we can consider implementing more units or extending the system to support composite units."

Some links:

HistogramSet: http://doc/1vWs1KOLDfv9YC8M_xfmHViwDxDC6wEWKjkQK1-nJmNs describes HistogramSet.
chartjson2histograms: https://github.com/catapult-project/catapult/blob/master/tracing/bin/chartjson2histograms.py

I'm not sure how big of an effort switching will be, particularly the OAuth pieces. Right now, I think that Tast is just generating chartjson data, with Autotest still responsible for uploading it.

Has anyone already looked at switching Autotest to use HistogramSet?
 

Comment 1 by pwang@chromium.org, Jan 17 (6 days ago)

I have already created a service account for hist OAuth but got multiple rejections from chromeperf dashboard weeks ago. Different errors code were reported but mostly are 403. 
I must missed some instruments, but didn't have a chance to looked at it.

What I did is (followed by the instruction)
1) Create service account under project chromeos-bot
2) Add the service account key file to lucifer. (Thanks to allen)
3) Add entry in catapult/dashboard/dashboard/api/api_auth.py

Applying chartjson2histograms locally on our chart data works without problem. It needs catapult repository to works, which I'm not sure if autotest have access to the codebase.

Sign in to add a comment