New issue
Advanced search Search tips

Issue 922820 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

compile failure on linux-chromeos-rel

Project Member Reported by afakhry@chromium.org, Jan 17 (6 days ago)

Issue description

linux-chromeos-rel: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/18711

[456/18828] ACTION //chrome/browser/resources/omnibox:closure_compile(//build/toolchain/linux:clang_x64)
FAILED: gen/chrome/browser/resources/omnibox/closure_compile.js 
python ../../third_party/closure_compiler/js_binary.py --compiler ../../third_party/closure_compiler/compiler/compiler.jar --output gen/chrome/browser/resources/omnibox/closure_compile.js --deps gen/chrome/browser/resources/omnibox/omnibox.js_library --sources --checks-only --flags extra_annotation_name=attribute extra_annotation_name=demo extra_annotation_name=element extra_annotation_name=group extra_annotation_name=hero extra_annotation_name=homepage extra_annotation_name=status extra_annotation_name=submodule jscomp_error=accessControls jscomp_error=ambiguousFunctionDecl jscomp_error=checkTypes jscomp_error=checkVars jscomp_error=constantProperty jscomp_error=deprecated jscomp_error=externsValidation jscomp_error=globalThis jscomp_error=invalidCasts jscomp_error=missingProperties jscomp_error=missingReturn jscomp_error=nonStandardJsDocs jscomp_error=suspiciousCode jscomp_error=undefinedNames jscomp_error=undefinedVars jscomp_error=unknownDefines jscomp_error=uselessCode jscomp_error=visibility compilation_level=SIMPLE_OPTIMIZATIONS language_in=ECMASCRIPT_2017 language_out=ECMASCRIPT5_STRICT chrome_pass polymer_pass jscomp_off=duplicate --externs ../../third_party/closure_compiler/externs/chrome.js ../../third_party/closure_compiler/externs/polymer-1.0.js
../../chrome/browser/resources/omnibox/omnibox_output.js:312: ERROR - Property forEach never defined on Element.prototype.matches
      this.matches.forEach(match => match.updateEliding(elideCells));
                   ^^^^^^^

1 error(s), 0 warning(s), 93.9% typed

Culprit CL is: https://chromium-review.googlesource.com/c/chromium/src/+/1407772

Reverting.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 17 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ba57f898a5173c4499096c529ac692bd6c7d727

commit 7ba57f898a5173c4499096c529ac692bd6c7d727
Author: Ahmed Fakhry <afakhry@chromium.org>
Date: Thu Jan 17 00:04:53 2019

Revert "[omnibox chrome:omnibox] Add checkbox to toggle cell eliding"

This reverts commit 3200e3e7f3e60874cb93faf451cef850f9b80054.

Reason for revert: Breaks compile on linux-chromeos-rel

BUG=922820

Original change's description:
> [omnibox chrome:omnibox] Add checkbox to toggle cell eliding
> 
> Bug: 891303
> Change-Id: I25ac8d8897d388e8f9fd92e0f175d878683ca83e
> Reviewed-on: https://chromium-review.googlesource.com/c/1407772
> Commit-Queue: manuk hovanesian <manukh@chromium.org>
> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#623452}

TBR=jdonnelly@chromium.org,manukh@chromium.org

Change-Id: Ib9f7544c7d79efbfe5ea07964267ae3d01b52f22
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 891303
Reviewed-on: https://chromium-review.googlesource.com/c/1416816
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623459}
[modify] https://crrev.com/7ba57f898a5173c4499096c529ac692bd6c7d727/chrome/browser/resources/omnibox/omnibox.html
[modify] https://crrev.com/7ba57f898a5173c4499096c529ac692bd6c7d727/chrome/browser/resources/omnibox/omnibox_input.js
[modify] https://crrev.com/7ba57f898a5173c4499096c529ac692bd6c7d727/chrome/browser/resources/omnibox/omnibox_output.js
[modify] https://crrev.com/7ba57f898a5173c4499096c529ac692bd6c7d727/chrome/browser/resources/omnibox/output_results_group.css

Sign in to add a comment