New issue
Advanced search Search tips

Issue 922813 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug

Blocking:
issue 866147



Sign in to add a comment

Convert common helpers and utilities for EG2

Project Member Reported by linds...@chromium.org, Jan 16 (6 days ago)

Issue description

Tracker bug
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 18 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5762107524c777007bc3985dbfd0d5727e4ba3d8

commit 5762107524c777007bc3985dbfd0d5727e4ba3d8
Author: Rohit Rao <rohitrao@chromium.org>
Date: Fri Jan 18 12:44:23 2019

[ios] Compiles ios/testing/earl_grey under both EG1 and EG2.

Adds new GN targets for compiling these test support files under EG2.
Rearranges ios/chrome/test/earl_grey2/BUILD.gn to clearly separate out
support libraries for the app and test processes.  Modifies the EG2
templates to automatically have EG2 app hosts and tests depend on the
appropriate support libraries.

BUG=922813

Change-Id: Iefcb72386389f2ed7339fcf9ce8edd13b28f08a2
Reviewed-on: https://chromium-review.googlesource.com/c/1418432
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624089}
[modify] https://crrev.com/5762107524c777007bc3985dbfd0d5727e4ba3d8/ios/chrome/test/earl_grey2/BUILD.gn
[modify] https://crrev.com/5762107524c777007bc3985dbfd0d5727e4ba3d8/ios/chrome/test/earl_grey2/chrome_ios_eg2_test.gni
[modify] https://crrev.com/5762107524c777007bc3985dbfd0d5727e4ba3d8/ios/testing/earl_grey/BUILD.gn
[modify] https://crrev.com/5762107524c777007bc3985dbfd0d5727e4ba3d8/ios/testing/earl_grey/matchers.h
[modify] https://crrev.com/5762107524c777007bc3985dbfd0d5727e4ba3d8/ios/testing/earl_grey/matchers.mm

Sign in to add a comment