New issue
Advanced search Search tips

Issue 922806 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jan 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

cros tryjob: email notifications not working

Project Member Reported by briannorris@chromium.org, Jan 16 (6 days ago)

Issue description

On a recent checkout (from ~1 day ago), I ran something like this:

  cros tryjob -g 1413169 cyan-no-vmtest-pre-cq

It gave me this:

https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8924143696749330608

It never sent me an email notification.

Spawned off of my mis-placed assumption that this was part of bug 921407.
 

Comment 1 by jclinton@google.com, Jan 17 (5 days ago)

Cc: mikenichols@chromium.org
Labels: -Pri-3 Pri-2
Owner: jclinton@chromium.org
Status: Assigned (was: Untriaged)
Mike, you recently reworked all of this to use LUCI Notify. Can you point me to a document or describe how this works?

Comment 2 by jclinton@google.com, Jan 17 (5 days ago)

Cc: cmt...@chromium.org
Caroline, you submit a lot of tryjobs: can you remember the last time that you got email notifications that they were complete?

Comment 3 by mikenichols@chromium.org, Jan 17 (5 days ago)

Luci-notify, for tryjobs, are using the email of the user (from git config) at the time of tryjob submission.  There should be no configuration unless a template tag, of a template that does not exist, is being provided at tryjob submission.  Right now ChromeOS utilizes a default template for the entire project:  https://chrome-internal.googlesource.com/chromeos/manifest-internal/+/5d4147a6a0eef305d8ef3a4827c6a2ab6788d641/luci-notify/email-templates/default.template

I was running tryjobs last night and received email notifications.  We've had a few occasions where notifications were stuck but it is rare and doesn't appear to be the case given that I've received them as recent as last night. 

-- Mike

Comment 4 by jclinton@chromium.org, Jan 17 (5 days ago)

Brian, is your gitconfig correct? Are you sure that you have email forwarding from chromium.org to google.com set up and that these aren't being filtered out?

Comment 5 by jclinton@chromium.org, Jan 17 (5 days ago)

Run `git config --get user.email` from where ever you were running the `cros tryjob` command, to confirm.

Comment 6 by briannorris@chromium.org, Jan 17 (5 days ago)

I have email forwarding, and I checked every corner of my inbox (including spam) -- no email.

Also, the Milo link:

https://ci.chromium.org/p/chromeos/builders/luci.chromeos.general/PreCQ/b8924143696749330608

mentions both my @google.com and my @chromium.org, for "created_by" and "cbb_email" respectively.

But speaking of git-config: I do have a global user.email that's different than my chromium settings. But my chromium repos are all set up to use @chromium.org. So when I run `git config --get user.email` from the chrmoiumos/ root, I get the wrong (non-chromium) account, because there's no local repo there -- and that happens to be where I ran `cros tryjob`.

So in case that matters, I'm retrying right now, with:

~/chromiumos/src/scripts$ cros tryjob -g 1413169 cyan-no-vmtest-pre-cq 
Tryjob submitted!
To view your tryjobs, visit:
  https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8924066327859596128
~/chromiumos/src/scripts$ git config --get user.email
briannorris@chromium.org

I don't feel like that has mattered historically.

Comment 7 by dgarr...@chromium.org, Jan 17 (5 days ago)

For what it's worth, notifications are working for me. My most recent tryjob was yesterday afternoon....

https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8924132471489127104

Comment 8 by dgarr...@chromium.org, Jan 17 (5 days ago)

Brian, any chance you fired off that tryjob from an older branch?

Email notifications only work if the tryjob was requested from a vaguely current version of "cros tryjob".

Comment 9 by briannorris@chromium.org, Jan 17 (5 days ago)

Status: WontFix (was: Assigned)
> Brian, any chance you fired off that tryjob from an older branch?

Not really. I'm synced with ToT, and my last sync was earlier this week. (depot_tools synced late-December -- but the 'cros' wrapper is very thin).

BTW, the job in #6 is behaving the same (no email). I traced `cros tryjob` and it's picking up the email from the git-config in .../chromite/ (which is correct), so that really couldn't have been the problem.

.
.
.

Uh oh....it's really my fault (well, sort of). I check my @google.com, and indeed, I do have forwarding set up correctly. But forwarding doesn't include the spam folder, and I forgot to explicitly go to my chromium.org and check *its* spam folder :(((

I'm very sorry for the waste of effort.

(Side note: I wonder if I should just disable spam filtering on the chromium.org side. I'm not sure if @google.com would then still do (legitimate) filtering then, but at least I'd only have 1 spam box to check.)

I'll call this WontFix, since there wasn't really anything to fix. Well, at least not anything relevant to this bug tracker, unless there's something that can be done to make LUCI notification emails appear less like spam to Gmail.

Sign in to add a comment