New issue
Advanced search Search tips

Issue 922802 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Mac
Pri: 2
Type: ----

Blocked on:
issue 913927
issue 922473

Blocking:
issue 922472



Sign in to add a comment

Replace use of AccountTrackerService in ios/web_view/internal/sync/cwv_sync_controller_unittest.mm

Project Member Reported by dxie@google.com, Jan 16 (6 days ago)

Issue description


 

Comment 1 by dxie@google.com, Jan 16 (6 days ago)

Components: Internals>Services>Identity
Labels: Proj-Servicification OS-Windows OS-Linux OS-Mac Proj-Servicification-VendorBug OS-Android Pri-2
Status: Available (was: Untriaged)

Comment 2 by dxie@google.com, Jan 17 (6 days ago)

Blockedon: 922473
Blocking: 922472
"API replacement summary:
- AccountTrackerService::SeedAccountInfo => IdentityTestEnvironment or identity_test_utils to make account available
"

Comment 3 by je_julie.kim@chromium.org, Jan 17 (6 days ago)

Owner: je_julie.kim@chromium.org
Status: Started (was: Available)

Comment 4 by je_julie.kim@chromium.org, Jan 17 (6 days ago)

Status: Assigned (was: Started)
For ios WebView, it doesn't expect that UpdateCredentials is called at
https://cs.chromium.org/chromium/src/components/signin/ios/browser/profile_oauth2_token_service_ios_delegate.mm?q=profile_oauth2_token_service_ios_delegate&sq=package:chromium&g=0&l=256.

AFIK, we don't have API only for SeedAccountInfo() in IdentityTestEnvironment or identity_test_utils.

So, I'll wait for IdentityManager::LegacySeedAccountInfo at  crbug.com/922473 .
If there is anything I missed, please let me know.

Comment 5 by je_julie.kim@chromium.org, Today (2 hours ago)

Blockedon: 913927
Now we can use LegacySeedAccountInfo instead of SeedAccountInfo but we need to remove the dependency of ProfileOAuth2TokenService in order to move cwv_sync_controller_unittest.mm away from using AccountTrackerService.

So, I added the issue, crbug.com/913927, to 'Blocked on' field.

Sign in to add a comment