New issue
Advanced search Search tips

Issue 922787 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Today
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Mac
Pri: 2
Type: ----


Sign in to add a comment

Replace use of AccountTrackerService in chrome/browser/ui/webui/settings/people_handler.cc

Project Member Reported by dxie@google.com, Jan 16 (6 days ago)

Issue description


 

Comment 1 by dxie@google.com, Jan 16 (6 days ago)

Components: Internals>Services>Identity
Labels: Proj-Servicification OS-Windows OS-Linux OS-Mac Proj-Servicification-VendorBug OS-Android Pri-2
Status: Available (was: Untriaged)

Comment 2 by dxie@google.com, Jan 17 (6 days ago)

Blockedon: 922470 922469
Blocking: 921061 912170 908858 914783
"API replacement summary:
- AccountTrackerService::Observer::OnAccountUpdated => IdentityManager::Observer::OnAccountUpdated
- AccountTrackerService::Observer::OnAccountRemoved => IdentityManager::Observer::OnAccountRemovedWithInfo
- AccountTrackerService::GetAccountInfo => IdentityManager::FindAccountInfoForAccountWithRefreshTokenByAccountId
- AccountTrackerService::GetAccountImage => IdentityManager::FindAccountInfoForAccountWithRefreshTokenByAccountId
- AccountTrackerService::FindAccountInfoByEmail => IdentityManager::FindAccountInfoForAccountWithRefreshTokenByEmailAddress
"

Comment 3 by je_julie.kim@chromium.org, Yesterday (27 hours ago)

Owner: je_julie.kim@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid, Today (7 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b171daf36371e7270b7a8fa44d90b00015381d5

commit 8b171daf36371e7270b7a8fa44d90b00015381d5
Author: Julie Jeongeun Kim <jkim@igalia.com>
Date: Tue Jan 22 23:02:14 2019

[s13n] Move PeopleHandler away from AccountTrackerService

This CL removes AccountTrackerService::Observer from PeopleHandler
as it can get OnAccountUpdated/OnAccountRemovedWithInfo through
IdentityManager::Observer.

Bug:  922787 
Change-Id: Ifb9a605f27bcadf991858836a813c5e80bbff556
Reviewed-on: https://chromium-review.googlesource.com/c/1426204
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#624978}
[modify] https://crrev.com/8b171daf36371e7270b7a8fa44d90b00015381d5/chrome/browser/ui/webui/settings/people_handler.cc
[modify] https://crrev.com/8b171daf36371e7270b7a8fa44d90b00015381d5/chrome/browser/ui/webui/settings/people_handler.h

Comment 5 by je_julie.kim@chromium.org, Today (21 minutes ago)

Status: Fixed (was: Started)

Sign in to add a comment