New issue
Advanced search Search tips

Issue 922770 link

Starred by 3 users

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Mac
Pri: 2
Type: ----

Blocked on:
issue 922471
issue 922473
issue 922474

Blocking:
issue 922472
issue 922476



Sign in to add a comment

Replace use of AccountTrackerService in chrome/browser/signin/dice_response_handler.cc

Project Member Reported by dxie@google.com, Jan 16 (6 days ago)

Issue description


 

Comment 1 by dxie@google.com, Jan 16 (6 days ago)

Components: Internals>Services>Identity
Labels: Proj-Servicification OS-Windows OS-Linux OS-Mac Proj-Servicification-VendorBug OS-Android Pri-2
Status: Available (was: Untriaged)

Comment 2 by dxie@google.com, Jan 17 (6 days ago)

Blockedon: 922471 922473 922474
Blocking: 922472 922476
"API replacement summary:
- AccountTrackerService::PickAccountIdForAccount => IdentityManager::LegacyPickAccountIdForAccount
- AccountTrackerService::SeedAccountInfo => IdentityManager::LegacySeedAccountInfo
- AccountTrackerService::SetIsAdvancedProtectionAccount => AccountsMutator::SetIsAdvancedProtectionAccount
"

Comment 3 by je_julie.kim@chromium.org, Yesterday (30 hours ago)

Owner: je_julie.kim@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid, Today (7 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36b1e11118bcab933e90ebd108c4ef7370d6e528

commit 36b1e11118bcab933e90ebd108c4ef7370d6e528
Author: Julie Jeongeun Kim <jkim@igalia.com>
Date: Tue Jan 22 23:02:47 2019

[s13n] Move DiceResponseHandler away from AccountTrackerService

This CL removes AccountTrackerService from DiceResponseHandler
and replaces PickAccountIdForAccount with
LegacyPickAccountIdForAccount.

Bug: 922770
Change-Id: I850042262ee267cfd660a116e4c0537022add9df
Reviewed-on: https://chromium-review.googlesource.com/c/1425845
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#624979}
[modify] https://crrev.com/36b1e11118bcab933e90ebd108c4ef7370d6e528/chrome/browser/signin/dice_response_handler.cc
[modify] https://crrev.com/36b1e11118bcab933e90ebd108c4ef7370d6e528/chrome/browser/signin/dice_response_handler.h
[modify] https://crrev.com/36b1e11118bcab933e90ebd108c4ef7370d6e528/chrome/browser/signin/dice_response_handler_unittest.cc

Sign in to add a comment