Replace use of AccountTrackerService in chrome/browser/password_manager/password_store_signin_notifier_impl.cc |
|||
Issue description
,
Today
(22 hours ago)
Let me take this bug.
,
Today
(16 hours ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f007a1cc45e80f9c5fd4277afbd2baa1580eebf commit 8f007a1cc45e80f9c5fd4277afbd2baa1580eebf Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Tue Jan 22 13:51:54 2019 s13n: Replace use of AccountTrackerService in password_store_signin_notifier_impl.cc As a step to use IdentityManager, this CL makes PasswordStoreSigninNotifierImpl implement IdentityManager::Observer::OnAccountRemoveWithInfo instead of AccountTrackerService::Observer::OnAccountRemoved. Bug: 922753 , 922754 Change-Id: I67195754277cf9316d268e365eddcd9df1ea5c13 Reviewed-on: https://chromium-review.googlesource.com/c/1426502 Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#624766} [modify] https://crrev.com/8f007a1cc45e80f9c5fd4277afbd2baa1580eebf/chrome/browser/password_manager/password_store_signin_notifier_impl.cc [modify] https://crrev.com/8f007a1cc45e80f9c5fd4277afbd2baa1580eebf/chrome/browser/password_manager/password_store_signin_notifier_impl.h
,
Today
(16 hours ago)
,
Today
(14 hours ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/88bc9e211098e9662dd5cfbc186bbeaca2d3c297 commit 88bc9e211098e9662dd5cfbc186bbeaca2d3c297 Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Tue Jan 22 15:51:53 2019 fixup! s13n: Replace use of AccountTrackerService in password_store_signin_notifier_impl.cc Missed to remove the include of account_tracker_service_factory.h in the previous CL. Bug: 922753 Change-Id: I9e9e4f33401d72cebaa3d2418a27e793ca1deac7 Reviewed-on: https://chromium-review.googlesource.com/c/1426255 Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#624791} [modify] https://crrev.com/88bc9e211098e9662dd5cfbc186bbeaca2d3c297/chrome/browser/password_manager/password_store_signin_notifier_impl.cc |
|||
►
Sign in to add a comment |
|||
Comment 1 by dxie@google.com
, Jan 16 (6 days ago)Labels: Proj-Servicification OS-Windows OS-Linux OS-Mac Proj-Servicification-VendorBug OS-Android Pri-2
Status: Available (was: Untriaged)