New issue
Advanced search Search tips

Issue 922753 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Today
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Mac
Pri: 2
Type: ----

Blocked on:
issue 922470

Blocking:
issue 921061



Sign in to add a comment

Replace use of AccountTrackerService in chrome/browser/password_manager/password_store_signin_notifier_impl.cc

Project Member Reported by dxie@google.com, Jan 16 (6 days ago)

Issue description


 

Comment 1 by dxie@google.com, Jan 16 (6 days ago)

Components: Internals>Services>Identity
Labels: Proj-Servicification OS-Windows OS-Linux OS-Mac Proj-Servicification-VendorBug OS-Android Pri-2
Status: Available (was: Untriaged)

Comment 2 by dxie@google.com, Jan 16 (6 days ago)

Blockedon: 922470
Blocking: 921061
"API replacement summary:
- AccountTrackerService::Observer::OnAccountRemoved => IdentityManager::Observer::OnAccountRemovedWithInfo
"

Comment 3 by gyuyo...@igalia.com, Today (22 hours ago)

Owner: gyuyo...@igalia.com
Status: Started (was: Available)
Let me take this bug.
Project Member

Comment 4 by bugdroid1@chromium.org, Today (16 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f007a1cc45e80f9c5fd4277afbd2baa1580eebf

commit 8f007a1cc45e80f9c5fd4277afbd2baa1580eebf
Author: Gyuyoung Kim <gyuyoung@igalia.com>
Date: Tue Jan 22 13:51:54 2019

s13n: Replace use of AccountTrackerService in password_store_signin_notifier_impl.cc

As a step to use IdentityManager, this CL makes PasswordStoreSigninNotifierImpl implement
IdentityManager::Observer::OnAccountRemoveWithInfo instead of
AccountTrackerService::Observer::OnAccountRemoved.

Bug:  922753 ,  922754 
Change-Id: I67195754277cf9316d268e365eddcd9df1ea5c13
Reviewed-on: https://chromium-review.googlesource.com/c/1426502
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#624766}
[modify] https://crrev.com/8f007a1cc45e80f9c5fd4277afbd2baa1580eebf/chrome/browser/password_manager/password_store_signin_notifier_impl.cc
[modify] https://crrev.com/8f007a1cc45e80f9c5fd4277afbd2baa1580eebf/chrome/browser/password_manager/password_store_signin_notifier_impl.h

Comment 5 by gyuyo...@igalia.com, Today (16 hours ago)

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Today (14 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88bc9e211098e9662dd5cfbc186bbeaca2d3c297

commit 88bc9e211098e9662dd5cfbc186bbeaca2d3c297
Author: Gyuyoung Kim <gyuyoung@igalia.com>
Date: Tue Jan 22 15:51:53 2019

fixup! s13n: Replace use of AccountTrackerService in password_store_signin_notifier_impl.cc

Missed to remove the include of account_tracker_service_factory.h in the previous CL.

Bug:  922753 
Change-Id: I9e9e4f33401d72cebaa3d2418a27e793ca1deac7
Reviewed-on: https://chromium-review.googlesource.com/c/1426255
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#624791}
[modify] https://crrev.com/88bc9e211098e9662dd5cfbc186bbeaca2d3c297/chrome/browser/password_manager/password_store_signin_notifier_impl.cc

Sign in to add a comment