New issue
Advanced search Search tips

Issue 922734 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 844360
Owner: ----
Closed: Jan 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

"--device=android" doesn't work

Project Member Reported by crouleau@chromium.org, Jan 16 (6 days ago)

Issue description

when I run
./tools/perf/run_benchmark system_health.memory_mobile --story-filter=browse:media:imgur --device=android --browser=android-chrome-dev

I get 

system_health.memory_mobile is disabled on the selected browser
This platform is not supported for this benchmark. If this is in error please add it to the benchmark's supported platforms.

So then I edited the story_runner.py code to print target_platform.GetDeviceTypeName() and discovered that it was "Desktop"
But I inputted --device=android.

I think this may have been regressed by https://chromium-review.googlesource.com/c/catapult/+/1050367/
 

Comment 1 by perezju@chromium.org, Jan 17 (5 days ago)

This also sounds related to issue 844360.
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 17 (5 days ago)

Comment 3 by crouleau@chromium.org, Jan 17 (5 days ago)

Mergedinto: 844360
Status: Duplicate (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 18 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c47537d42e1cfb7f3ff655a450fd0b026a15b33b

commit c47537d42e1cfb7f3ff655a450fd0b026a15b33b
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Fri Jan 18 11:33:56 2019

Roll src/third_party/catapult a0e5e3328cd7..8e77731b1363 (6 commits)

https://chromium.googlesource.com/catapult.git/+log/a0e5e3328cd7..8e77731b1363


git log a0e5e3328cd7..8e77731b1363 --date=short --no-merges --format='%ad %ae %s'
2019-01-17 crouleau@chromium.org Revert "Stop splitting logcat output on carriage returns."
2019-01-17 crouleau@chromium.org Revert "Ignore zeros in Breakdowns."
2019-01-17 uwyiming@google.com Add an option in WPR replay to prefer previously unmatched responses.
2019-01-17 crouleau@chromium.org [Telemetry] Cleanup: Remove unused argument from FindAllBrowserTypes
2019-01-17 uwyiming@google.com Adding uwyiming (myself) as an owner to WPR.
2019-01-17 skym@chromium.org Stop splitting logcat output on carriage returns.


Created with:
  gclient setdep -r src/third_party/catapult@8e77731b1363

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:919223,chromium:919223,chromium:923125, chromium:922734 ,chromium:922828,chromium:919223
TBR=sullivan@chromium.org

Change-Id: I7fc110d1697c8624cf391c634fa26204b3bef617
Reviewed-on: https://chromium-review.googlesource.com/c/1419365
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#624077}
[modify] https://crrev.com/c47537d42e1cfb7f3ff655a450fd0b026a15b33b/DEPS

Sign in to add a comment