New issue
Advanced search Search tips

Issue 922699 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Remove legacy HostResolver API

Project Member Reported by ericorth@chromium.org, Jan 16 (6 days ago)

Issue description

As part of servicification, created a new API in net::HostResolver (and mirrored that new API in network service as a mojo API).  Design doc: https://docs.google.com/document/d/1NmADJX00oRe9TxFCJTWl8ofdfyR22pbKT8-5Ad5lBsU/edit#heading=h.7nki9mck5t64

As a followup, need to convert all usage of the old API (Resolve(...)) to the new API (CreateRequest(...)) and delete the old API.
 

Comment 1 by ericorth@chromium.org, Jan 16 (6 days ago)

Components: Internals>Network>DNS
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 17 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/343d88c9b5c424b96f6e27d8ab4f2084636e485e

commit 343d88c9b5c424b96f6e27d8ab4f2084636e485e
Author: Eric Orth <ericorth@chromium.org>
Date: Thu Jan 17 17:46:37 2019

Convert FtpNetworkTransaction to new HostResolver API

Bug: 922699
Change-Id: I6d697234bf8f809538829dae8c8b6ea9fe41147e
Reviewed-on: https://chromium-review.googlesource.com/c/1416397
Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623743}
[modify] https://crrev.com/343d88c9b5c424b96f6e27d8ab4f2084636e485e/net/ftp/ftp_network_transaction.cc
[modify] https://crrev.com/343d88c9b5c424b96f6e27d8ab4f2084636e485e/net/ftp/ftp_network_transaction.h

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 17 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a094b3f406228a27463a45ab3fdcbc190925d2ef

commit a094b3f406228a27463a45ab3fdcbc190925d2ef
Author: Eric Orth <ericorth@chromium.org>
Date: Thu Jan 17 23:46:39 2019

Convert HttpAuthHandlerNegotiate to new HostResolver API

Little bit of reworking how the results are processed.  Now that
results are only present when there was a resolve, rather than having a
potentially blank, potentially filled in AddressList, moved the
processing to handle reading the server/cannonname to the resolve-done
method.

Bug: 922699
Change-Id: I40abf84ef256c1784e262fd4b2792ad3677c8bf5
Reviewed-on: https://chromium-review.googlesource.com/c/1416400
Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623910}
[modify] https://crrev.com/a094b3f406228a27463a45ab3fdcbc190925d2ef/net/http/http_auth_handler_negotiate.cc
[modify] https://crrev.com/a094b3f406228a27463a45ab3fdcbc190925d2ef/net/http/http_auth_handler_negotiate.h
[modify] https://crrev.com/a094b3f406228a27463a45ab3fdcbc190925d2ef/net/http/http_auth_handler_negotiate_unittest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 18 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/434444945e20b4721dd962663dfe4ffa8af985d4

commit 434444945e20b4721dd962663dfe4ffa8af985d4
Author: Eric Orth <ericorth@chromium.org>
Date: Fri Jan 18 03:32:07 2019

Convert PacFileDecider to new HostResolver API

Bug: 922699
Change-Id: I5ce40c35e3711f90979cd2ad38ad8764c7a86def
Reviewed-on: https://chromium-review.googlesource.com/c/1419137
Auto-Submit: Eric Orth <ericorth@chromium.org>
Commit-Queue: Asanka Herath <asanka@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623991}
[modify] https://crrev.com/434444945e20b4721dd962663dfe4ffa8af985d4/net/proxy_resolution/pac_file_decider.cc
[modify] https://crrev.com/434444945e20b4721dd962663dfe4ffa8af985d4/net/proxy_resolution/pac_file_decider.h

Sign in to add a comment