Do not short-circuit android-binary-size when footer is present |
|||
Issue descriptionThe recipe currently skips all analysis when Binary-Size: footer is present. The rationale was to not slow down devs when they need to add the footer, and that you can always refer to prior patchsets to find the analysis. We've now seen that: * Adding Binary-Size: is pretty uncommon * It's not always accurate to look at older patchsets (changes can happen after origin patchset) We should remove the short-circuit logic here: https://cs.chromium.org/chromium/build/scripts/slave/recipes/binary_size_trybot.py?rcl=0d10eb44532003a23b2fd831fb37db2838eabb8b&l=78
,
Jan 16
(6 days ago)
Another reason not to short-circuit: the android-binary-size trybot is the only trybot that has is_official_build coverage
,
Jan 21
(2 days ago)
,
Yesterday
(38 hours ago)
|
|||
►
Sign in to add a comment |
|||
Comment 1 by agrieve@chromium.org
, Jan 16 (6 days ago)