New issue
Advanced search Search tips

Issue 922680 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Do not short-circuit android-binary-size when footer is present

Project Member Reported by agrieve@chromium.org, Jan 16 (6 days ago)

Issue description

The recipe currently skips all analysis when Binary-Size: footer is present.

The rationale was to not slow down devs when they need to add the footer, and that you can always refer to prior patchsets to find the analysis.

We've now seen that:
* Adding Binary-Size: is pretty uncommon
* It's not always accurate to look at older patchsets (changes can happen after origin patchset)

We should remove the short-circuit logic here:

https://cs.chromium.org/chromium/build/scripts/slave/recipes/binary_size_trybot.py?rcl=0d10eb44532003a23b2fd831fb37db2838eabb8b&l=78
 

Comment 1 by agrieve@chromium.org, Jan 16 (6 days ago)

Cc: mheikal@chromium.org

Comment 2 by estevenson@chromium.org, Jan 16 (6 days ago)

Another reason not to short-circuit: the android-binary-size trybot is the only trybot that has is_official_build coverage

Comment 3 by agrieve@chromium.org, Jan 21 (2 days ago)

Owner: agrieve@chromium.org
Status: Started (was: Available)

Comment 4 by agrieve@chromium.org, Yesterday (38 hours ago)

Labels: binary_size_team_q1_2019

Sign in to add a comment