New issue
Advanced search Search tips

Issue 922674 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Delete benchmark_sharding_map.json and other out of date files

Project Member Reported by crouleau@chromium.org, Jan 16 (6 days ago)

Issue description

I don't think https://cs.chromium.org/chromium/src/tools/perf/core/benchmark_sharding_map.json is in use anymore. COuld we delete it?


 

Comment 1 by eyaich@chromium.org, Jan 17 (5 days ago)

yes this can be deleted.

Comment 2 by crouleau@chromium.org, Jan 17 (5 days ago)

Cc: perezju@chromium.org
Great! I will delete it.

Emily, can you please read through the src/tools/perf directory and its subfolders and let me know of all the files you know of that can be removed?
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 19 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/184ef227d583f68c92e058c06ff2943ea12eef5b

commit 184ef227d583f68c92e058c06ff2943ea12eef5b
Author: Caleb Rouleau <crouleau@chromium.org>
Date: Sat Jan 19 00:39:26 2019

[Benchmarking] Cleanup: delete unused benchmark_sharding_map.json

Bug: 922674
Change-Id: I67089790486a3e38cd5cd580316f003f131a51ca
Reviewed-on: https://chromium-review.googlesource.com/c/1418122
Auto-Submit: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624383}
[delete] https://crrev.com/7dd5adc397e4f9181bec63d7a4c5d852121c8bde/tools/perf/core/benchmark_sharding_map.json

Sign in to add a comment