New issue
Advanced search Search tips

Issue 922662 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Always prefer entity suggestions when deduping (take 2)

Project Member Reported by jdonnelly@chromium.org, Jan 16 (6 days ago)

Issue description

My previous attempt at preferring entity suggestions ( bug 913299 ) had a limitation in that it only worked when the entity suggestion was allowed_to_be_default_match. This often worked because of a related change I made (https://crrev.com/c/1376318) that set this value on entity suggestions if they matched the previous cycle's top match. But we could still fail to prefer entity suggestions if they didn't fall under this case.

However, the intent is that entity suggestions should always be preferred over an equivalent non-entity suggestion. Equivalent is defined as: has the same stripped destination URL and has the same fill_into_edit.

In order to do this, it will also be necessary to set allowed_to_be_default_match to true on all entity suggestions selected during the deduping process, if any of the other candidate matches being deduped has this value, to avoid re-introducing a version of bug 542780. 
 

Sign in to add a comment