New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 922643 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jan 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

"finalize annotations" should be "exculpate CLs"

Project Member Reported by semenzato@chromium.org, Jan 16 (6 days ago)

Issue description

I don't know if I understand correctly, but after clicking "finalize" and "save changes", annotations on the annotator (go/cros-build-annotator) can still be edited, added, and deleted.

So the meaning of "finalize" is unclear, but from the description in go/cros-sheriff-faq it seems that it really means "exonerate all CLs from previous run unless set to Verified -1".
 

Comment 1 by semenzato@chromium.org, Jan 16 (6 days ago)

Summary: "finalize annotations" should be "exculpate CLs" (was: "finalizing annotations" should be "exculpate CLs")

Comment 2 by jclinton@chromium.org, Jan 16 (6 days ago)

Status: WontFix (was: Untriaged)
This tool is shutting down in about a quarter; we probably won't push the code for it again before then.

Sign in to add a comment