New issue
Advanced search Search tips

Issue 922635 link

Starred by 1 user
Status: Started
Owner:
fdegans@chromium.org
Cc:
sergeyu@chromium.org
w...@chromium.org
kmarshall@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 1
Type: Bug



Sign in to add a comment

Re-organize the //webrunner directory

Project Member Reported by fdegans@chromium.org, Jan 16 (6 days ago) 
The //webrunner directory has evolved beyond containing only code for the "webrunner" Fuchsia component. This is a tracking bug to implement a plan that will:
-Rename the directory to //fuchsia
-Make one subdirectory per Fuchsia component, including their respective test code
-Put code that is not shared across multiple binaries in non-namespaced C++.
-Document all the decisions taken in //fuchsia/README.md

Comment 1 by fdegans@chromium.org, Jan 16 (6 days ago)

Cc: sergeyu@chromium.org kmarshall@chromium.org w...@chromium.org

Comment 2 by w...@chromium.org, Jan 16 (6 days ago)

Labels: -Pri-2 M-74 Pri-1
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 17 (5 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/570201a211e071c540990d52f2a313348234e78a

commit 570201a211e071c540990d52f2a313348234e78a
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Thu Jan 17 23:32:33 2019

[Fuchsia] Rename //webrunner to //fuchsia

This also modifies all affected header includes and target names.
In addition, the "gn_all" target dependencies are reduced to what is
actually needed there for Fuchsia. It used to be "all" did not build
on Fuchsia and we relied on the "gn_all" target to build but this is
no longer the case.

Bug: 922635
Change-Id: I43c69ed511ff34b28210967287c35d2bfcad2d53
Reviewed-on: https://chromium-review.googlesource.com/c/1416110
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623907}
[modify] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/.gn
[modify] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/BUILD.gn
[modify] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/PRESUBMIT.py
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/BUILD.gn
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/DEPS
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/OWNERS
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/README.md
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/app/cast/application_config_manager/application_config_manager.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/app/cast/application_config_manager/application_config_manager.h
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/app/cast/application_config_manager/application_config_manager_unittest.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/app/cast/application_config_manager/main.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/app/cast/application_config_manager/sandbox_policy
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/app/cast/application_config_manager/test/fake_application_config_manager.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/app/cast/application_config_manager/test/fake_application_config_manager.h
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/app/cast/bindings/cast_channel.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/app/cast/bindings/cast_channel.h
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/app/cast/bindings/cast_channel.js
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/app/cast/bindings/cast_channel_browsertest.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/app/cast/cast_runner.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/app/cast/cast_runner.h
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/app/cast/cast_runner_integration_test.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/app/cast/cast_runner_unittest.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/app/cast/main.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/app/cast/sandbox_policy
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/app/cast/test/data/cast_channel.html
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/app/cast/test/data/cast_channel_reconnect.html
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/app/cast/test_common.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/app/cast/test_common.h
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/app/common/web_component.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/app/common/web_component.h
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/app/common/web_content_runner.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/app/common/web_content_runner.h
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/app/web/main.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/app/web/sandbox_policy
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/app/web/webrunner_smoke_test.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/browser/DEPS
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/browser/context_impl.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/browser/context_impl.h
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/browser/context_impl_browsertest.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/browser/frame_impl.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/browser/frame_impl.h
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/browser/frame_impl_browsertest.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/browser/message_port_impl.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/browser/message_port_impl.h
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/browser/test/data/dynamic_title.html
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/browser/test/data/message_port.html
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/browser/test/data/title1.html
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/browser/test/data/title2.html
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/browser/test/data/window_post_message.html
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/browser/webrunner_browser_context.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/browser/webrunner_browser_context.h
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/browser/webrunner_browser_main.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/browser/webrunner_browser_main.h
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/browser/webrunner_browser_main_parts.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/browser/webrunner_browser_main_parts.h
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/browser/webrunner_content_browser_client.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/browser/webrunner_content_browser_client.h
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/browser/webrunner_net_log.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/browser/webrunner_net_log.h
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/browser/webrunner_screen.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/browser/webrunner_screen.h
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/browser/webrunner_url_request_context_getter.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/browser/webrunner_url_request_context_getter.h
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/cipd/build_id.template
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/cipd/castrunner.yaml
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/cipd/fidl.yaml
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/cipd/http.yaml
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/cipd/webrunner.yaml
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/common/DEPS
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/common/OWNERS
[add] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/common/fuchsia_export.h
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/common/mem_buffer_util.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/common/mem_buffer_util.h
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/common/named_message_port_connector.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/common/named_message_port_connector.h
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/common/named_message_port_connector.js
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/common/named_message_port_connector_browsertest.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/common/on_load_script_injector.mojom
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/common/test/data/connector.html
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/common/test/test_common.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/common/test/test_common.h
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/common/test/webrunner_browser_test.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/common/test/webrunner_browser_test.h
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/common/test/webrunner_test_launcher.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/common/webrunner_content_client.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/common/webrunner_content_client.h
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/fidl/cast/application_config.fidl
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/fidl/cast/cast_channel.fidl
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/fidl/web/context.fidl
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/fidl/web/context_provider.fidl
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/fidl/web/frame.fidl
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/fidl/web/navigation_controller.fidl
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/fidl/web/navigation_event_observer.fidl
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/net_http/BUILD.gn
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/net_http/http_service_impl.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/net_http/http_service_impl.h
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/net_http/http_service_main.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/net_http/http_service_unittest.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/net_http/sandbox_policy
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/net_http/testdata/redirect-test.html
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/net_http/testdata/redirect-test.html.mock-http-headers
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/net_http/testdata/simple.html
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/net_http/testdata/simple.html.mock-http-headers
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/net_http/testdata/with-duplicate-headers.html
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/net_http/testdata/with-duplicate-headers.html.mock-http-headers
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/net_http/testdata/with-headers.html
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/net_http/testdata/with-headers.html.mock-http-headers
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/net_http/url_loader_impl.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/net_http/url_loader_impl.h
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/renderer/DEPS
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/renderer/on_load_script_injector.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/renderer/on_load_script_injector.h
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/renderer/webrunner_content_renderer_client.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/renderer/webrunner_content_renderer_client.h
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/service/DEPS
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/service/common.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/service/common.h
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/service/context_provider_impl.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/service/context_provider_impl.h
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/service/context_provider_impl_unittest.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/service/context_provider_main.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/service/context_provider_main.h
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/service/sandbox_policy
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/service/web_content_service_main.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/service/webrunner_main_delegate.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/service/webrunner_main_delegate.h
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/test/fake_context.cc
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/test/fake_context.h
[rename] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/fuchsia/test/promise.h
[modify] https://crrev.com/570201a211e071c540990d52f2a313348234e78a/testing/buildbot/gn_isolate_map.pyl
[delete] https://crrev.com/ff5adf1e182966bb806a31d3148cd49df3a3aa6b/webrunner/common/webrunner_export.h
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 17 (5 days ago) 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/release/scripts/+/ae489bd06995ec0a4c042c28a0938664eb2cd033

commit ae489bd06995ec0a4c042c28a0938664eb2cd033
Author: Fabrice de Gans-Riberi <fdegans@google.com>
Date: Thu Jan 17 23:40:49 2019
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 19 (4 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b28b7027e56f67bfff7fe4cb2dd7d76143513d9d

commit b28b7027e56f67bfff7fe4cb2dd7d76143513d9d
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Sat Jan 19 01:06:25 2019

[Fuchsia] Remove application_config_manager stub implementation.

This was not used anywhere outside of a test target that was not
run. This CL only keeps the fake implementation used for cast_runner
tests.

Bug: 922635
Change-Id: I0b7c71465cd5d6292a765df6a5193c715d7a172a
Reviewed-on: https://chromium-review.googlesource.com/c/1422868
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624394}
[modify] https://crrev.com/b28b7027e56f67bfff7fe4cb2dd7d76143513d9d/fuchsia/BUILD.gn
[delete] https://crrev.com/a777a9c86ec21e73d487a90394163b2cb689e4b2/fuchsia/app/cast/application_config_manager/application_config_manager.cc
[delete] https://crrev.com/a777a9c86ec21e73d487a90394163b2cb689e4b2/fuchsia/app/cast/application_config_manager/application_config_manager.h
[delete] https://crrev.com/a777a9c86ec21e73d487a90394163b2cb689e4b2/fuchsia/app/cast/application_config_manager/application_config_manager_unittest.cc
[delete] https://crrev.com/a777a9c86ec21e73d487a90394163b2cb689e4b2/fuchsia/app/cast/application_config_manager/main.cc
[delete] https://crrev.com/a777a9c86ec21e73d487a90394163b2cb689e4b2/fuchsia/app/cast/application_config_manager/sandbox_policy
[modify] https://crrev.com/b28b7027e56f67bfff7fe4cb2dd7d76143513d9d/fuchsia/app/cast/cast_runner_integration_test.cc
[modify] https://crrev.com/b28b7027e56f67bfff7fe4cb2dd7d76143513d9d/fuchsia/app/cast/cast_runner_unittest.cc
[rename] https://crrev.com/b28b7027e56f67bfff7fe4cb2dd7d76143513d9d/fuchsia/app/cast/fake_application_config_manager.cc
[rename] https://crrev.com/b28b7027e56f67bfff7fe4cb2dd7d76143513d9d/fuchsia/app/cast/fake_application_config_manager.h
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 19 (4 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9022d392155f62245b09af4b1ff7025dc785f0d

commit a9022d392155f62245b09af4b1ff7025dc785f0d
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Sat Jan 19 02:42:25 2019

[Fuchsia] Rename //fuchsia/net_http to //fuchsia/http.

This makes the directory layout consistent with the name of the
Fuchsia package it contains. In addition, this CL removes the C++
namespace in this part of the //fuchsia directory as this code is not
called from anywhere else. This CL also cleans up the build file,
using more common target names and setting the proper visibility to
targets.

TBR=jbudorick@chromium.org

Bug: 922635
Change-Id: I47f512e1bfb76dfca98261c884f4fec2da11a23d
Reviewed-on: https://chromium-review.googlesource.com/c/1423087
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624428}
[modify] https://crrev.com/a9022d392155f62245b09af4b1ff7025dc785f0d/BUILD.gn
[modify] https://crrev.com/a9022d392155f62245b09af4b1ff7025dc785f0d/fuchsia/BUILD.gn
[rename] https://crrev.com/a9022d392155f62245b09af4b1ff7025dc785f0d/fuchsia/http/BUILD.gn
[rename] https://crrev.com/a9022d392155f62245b09af4b1ff7025dc785f0d/fuchsia/http/http_service_impl.cc
[rename] https://crrev.com/a9022d392155f62245b09af4b1ff7025dc785f0d/fuchsia/http/http_service_impl.h
[rename] https://crrev.com/a9022d392155f62245b09af4b1ff7025dc785f0d/fuchsia/http/http_service_main.cc
[rename] https://crrev.com/a9022d392155f62245b09af4b1ff7025dc785f0d/fuchsia/http/http_service_unittest.cc
[rename] https://crrev.com/a9022d392155f62245b09af4b1ff7025dc785f0d/fuchsia/http/sandbox_policy
[rename] https://crrev.com/a9022d392155f62245b09af4b1ff7025dc785f0d/fuchsia/http/testdata/redirect-test.html
[rename] https://crrev.com/a9022d392155f62245b09af4b1ff7025dc785f0d/fuchsia/http/testdata/redirect-test.html.mock-http-headers
[rename] https://crrev.com/a9022d392155f62245b09af4b1ff7025dc785f0d/fuchsia/http/testdata/simple.html
[rename] https://crrev.com/a9022d392155f62245b09af4b1ff7025dc785f0d/fuchsia/http/testdata/simple.html.mock-http-headers
[rename] https://crrev.com/a9022d392155f62245b09af4b1ff7025dc785f0d/fuchsia/http/testdata/with-duplicate-headers.html
[rename] https://crrev.com/a9022d392155f62245b09af4b1ff7025dc785f0d/fuchsia/http/testdata/with-duplicate-headers.html.mock-http-headers
[rename] https://crrev.com/a9022d392155f62245b09af4b1ff7025dc785f0d/fuchsia/http/testdata/with-headers.html
[rename] https://crrev.com/a9022d392155f62245b09af4b1ff7025dc785f0d/fuchsia/http/testdata/with-headers.html.mock-http-headers
[rename] https://crrev.com/a9022d392155f62245b09af4b1ff7025dc785f0d/fuchsia/http/url_loader_impl.cc
[rename] https://crrev.com/a9022d392155f62245b09af4b1ff7025dc785f0d/fuchsia/http/url_loader_impl.h
[modify] https://crrev.com/a9022d392155f62245b09af4b1ff7025dc785f0d/testing/buildbot/gn_isolate_map.pyl
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 19 (4 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1dd3c78b671a85076dfecd5239fdf8ba4987c77

commit e1dd3c78b671a85076dfecd5239fdf8ba4987c77
Author: Wez <wez@chromium.org>
Date: Sat Jan 19 05:05:37 2019

[Fuchsia] Fix GN isolate map label for castrunner_browsertests.

TBR=jbudorick

Bug: 922635
Change-Id: Ie3d39b4ca2097a9a9e8061092e30394079c85260
Reviewed-on: https://chromium-review.googlesource.com/c/1423674
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Auto-Submit: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624446}
[modify] https://crrev.com/e1dd3c78b671a85076dfecd5239fdf8ba4987c77/testing/buildbot/gn_isolate_map.pyl
►

Sign in to add a comment