It would be great to see if we can get something in before the M72 stable cut next Tuesday. 

Patch is out for review: https://chromium-review.googlesource.com/c/chromium/src/+/1416230

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11338555469fdda19fb69f9c232956dee8161931

commit 11338555469fdda19fb69f9c232956dee8161931
Author: Filip Gorski <fgorski@chromium.org>
Date: Thu Jan 17 00:52:18 2019

[EoC] Fixing the experiment IDs problem

IDs were not sent with request, because an incorrect URL was passed
for validation. This fixes the problem and adds an appropriate test.

Bug:  922604 
Change-Id: Ifb288c9dd1cba073292d835b5f06610c84625924
Reviewed-on: https://chromium-review.googlesource.com/c/1416230
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623476}
[modify] https://crrev.com/11338555469fdda19fb69f9c232956dee8161931/components/ntp_snippets/contextual/contextual_suggestions_fetch.cc
[modify] https://crrev.com/11338555469fdda19fb69f9c232956dee8161931/components/ntp_snippets/contextual/contextual_suggestions_fetch.h
[modify] https://crrev.com/11338555469fdda19fb69f9c232956dee8161931/components/ntp_snippets/contextual/contextual_suggestions_fetch_unittest.cc

I was trying to verify this on today's canary, but I am getting crash covered by issue 923031.

Asked Tim for verification server side.

Good news is that this does not crash canary. It is a separate issue in net-export.

Theresa is trying to verify that, as all of my devices crash in net-exports

Requesting a merge. This is low risk and enables us to drive GWS driven experiments in M72

This bug requires manual review: We are only 10 days from stable.
Please contact the milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Before we approve merge to M72, please answer followings:
* Is this M72 regression? Is it critical?
* Is the change well baked/verified in Canary, having enough automation tests coverage and safe to merge to M72
* Any other important details to justify the merge.
* Is this feature behind Finch? 

Please note M72 is going to stable soon, so merge bar is ** VERY** high. Thank you.

Before we approve merge to M72, please answer followings:
* Is this M72 regression? Is it critical?
-- This path was never taken before. It is critical in the sense that we want to drive GWS experiment through Finch and there is no other way.

* Is the change well baked/verified in Canary, having enough automation tests coverage and safe to merge to M72
Yes. Most of the patch is automated test verifying it.
Manual test worked.
No new crashes. (over 1 day in canary)

* Any other important details to justify the merge.
See above -- the only way to drive GWS experiments for the feature through Finch.


* Is this feature behind Finch? 
Yes, per above.

Approving merge to M72 branch 3626 based on comments #1, #6 and #9. Please merge ASAP. Thank you.

The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/902a60e8e0fb41603d7d627b78a47bf490960376

Commit: 902a60e8e0fb41603d7d627b78a47bf490960376
Author: fgorski@chromium.org
Commiter: twellington@chromium.org
Date: 2019-01-18 21:06:23 +0000 UTC

[EoC] Fixing the experiment IDs problem

IDs were not sent with request, because an incorrect URL was passed
for validation. This fixes the problem and adds an appropriate test.

Bug:  922604 
Change-Id: Ifb288c9dd1cba073292d835b5f06610c84625924
Reviewed-on: https://chromium-review.googlesource.com/c/1416230
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#623476}(cherry picked from commit 11338555469fdda19fb69f9c232956dee8161931)
Reviewed-on: https://chromium-review.googlesource.com/c/1422669
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#735}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Thanks govind@!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/902a60e8e0fb41603d7d627b78a47bf490960376

commit 902a60e8e0fb41603d7d627b78a47bf490960376
Author: Filip Gorski <fgorski@chromium.org>
Date: Fri Jan 18 21:06:23 2019

[EoC] Fixing the experiment IDs problem

IDs were not sent with request, because an incorrect URL was passed
for validation. This fixes the problem and adds an appropriate test.

Bug:  922604 
Change-Id: Ifb288c9dd1cba073292d835b5f06610c84625924
Reviewed-on: https://chromium-review.googlesource.com/c/1416230
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#623476}(cherry picked from commit 11338555469fdda19fb69f9c232956dee8161931)
Reviewed-on: https://chromium-review.googlesource.com/c/1422669
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#735}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/902a60e8e0fb41603d7d627b78a47bf490960376/components/ntp_snippets/contextual/contextual_suggestions_fetch.cc
[modify] https://crrev.com/902a60e8e0fb41603d7d627b78a47bf490960376/components/ntp_snippets/contextual/contextual_suggestions_fetch.h
[modify] https://crrev.com/902a60e8e0fb41603d7d627b78a47bf490960376/components/ntp_snippets/contextual/contextual_suggestions_fetch_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6dfd29052ed7d149febc968103e8619c9d4bb4e3

commit 6dfd29052ed7d149febc968103e8619c9d4bb4e3
Author: Olivier Robin <olivierrobin@chromium.org>
Date: Tue Jan 22 18:17:05 2019

Reset VariationsHttpHeaderProvider in ContextualSuggestionsFetch tests

variations::VariationsHttpHeaderProvider must be resetted to avoid
interactions with other tests.

Bug: 924093,  922604 
Change-Id: I86ed096e117a98a5b7dcb11eca89daca2e97b8f4
Reviewed-on: https://chromium-review.googlesource.com/c/1425710
Auto-Submit: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624835}
[modify] https://crrev.com/6dfd29052ed7d149febc968103e8619c9d4bb4e3/components/ntp_snippets/contextual/contextual_suggestions_fetch_unittest.cc