New issue
Advanced search Search tips

Issue 922592 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Batch deleting SkImages in SkiaRenderer

Project Member Reported by backer@chromium.org, Jan 16 (6 days ago)

Issue description

We may return several tiles to a child at once in DisplayResourceProvider. It would be better to batch the DestroySkImage calls to minimize overhead.
 

Comment 1 by backer@chromium.org, Jan 16 (6 days ago)

Cc: penghuang@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 17 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff5adf1e182966bb806a31d3148cd49df3a3aa6b

commit ff5adf1e182966bb806a31d3148cd49df3a3aa6b
Author: Jonathan Backer <backer@chromium.org>
Date: Thu Jan 17 23:31:42 2019

Batch release of SkImages on GPU main thread

Bug: 922592
Change-Id: Ib0644fb49b4e2000e53861144d45906c28a931ef
Reviewed-on: https://chromium-review.googlesource.com/c/1418495
Commit-Queue: Jonathan Backer <backer@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623906}
[modify] https://crrev.com/ff5adf1e182966bb806a31d3148cd49df3a3aa6b/components/viz/service/display/display_resource_provider.cc
[modify] https://crrev.com/ff5adf1e182966bb806a31d3148cd49df3a3aa6b/components/viz/service/display/display_resource_provider.h
[modify] https://crrev.com/ff5adf1e182966bb806a31d3148cd49df3a3aa6b/components/viz/service/display/display_resource_provider_unittest.cc
[modify] https://crrev.com/ff5adf1e182966bb806a31d3148cd49df3a3aa6b/components/viz/service/display/skia_output_surface.h
[modify] https://crrev.com/ff5adf1e182966bb806a31d3148cd49df3a3aa6b/components/viz/service/display/skia_renderer.cc
[modify] https://crrev.com/ff5adf1e182966bb806a31d3148cd49df3a3aa6b/components/viz/service/display_embedder/skia_output_surface_impl.cc
[modify] https://crrev.com/ff5adf1e182966bb806a31d3148cd49df3a3aa6b/components/viz/service/display_embedder/skia_output_surface_impl.h
[modify] https://crrev.com/ff5adf1e182966bb806a31d3148cd49df3a3aa6b/components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.cc
[modify] https://crrev.com/ff5adf1e182966bb806a31d3148cd49df3a3aa6b/components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.h

Sign in to add a comment