Fix spacing of icons in Autofill section (Settings) |
|||||
Issue descriptionThe spacing of the icons in the Passwords, Payment methods and Addresses icons should be adjusted after moving these items in their own card (used to be aligned with user avatar in People card). The spacing should be the same in the "On startup" section. See attached image. Could you take a look? Thanks!
,
Jan 16
(6 days ago)
Hey Max, just to make sure I understand: You want me to break the aligning with the People section and have it aligned with the on start-up section, correct? I.e. something like this: http://screen/VXhxqcZDvVw If this is what you want, the padding around the icons needs to be 18 dp on each side, given that the icons are technically 20x20 and the radio buttons are 16x16. But of course this should be do-able. A few follow-up questions: Do you want me to also change the padding on the right of the row, i.e. to the right of the sub-page arrow? I assume not, but given that we currently use there a padding of 20dp as well I thought I'd double check. Also, is P2 accurately capturing the semantics of this issue? Asked another way: Is it fine to fix this in M73, or do you consider this blocking for the launch of the Autofill section, which will happen in M72?
,
Jan 17
(5 days ago)
>> ...given that the icons are technically 20x20 and the radio buttons are 16x16. Thanks for pointing that out! In that case, let's use the existing icon spacing as used for similar items like content settings (see attachment) which is 20dp on each side. >> A few follow-up questions: Do you want me to also change the padding on the right of the row, i.e. to the right of the sub-page arrow? I assume not, but given that we currently use there a padding of 20dp as well I thought I'd double check. No, this should be consistent with all other row items (20dp). Thanks for checking! >> ...do you consider this blocking for the launch of the Autofill section, which will happen in M72? No, it's not urgent. Changed prio to 3.
,
Jan 18
(4 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4081c99e3f4a12645a513c71d86e4653f49e2530 commit 4081c99e3f4a12645a513c71d86e4653f49e2530 Author: jdoerrie <jdoerrie@chromium.org> Date: Fri Jan 18 20:16:28 2019 [Settings WebUI] Center Autofill Section Icons This change modifies the spacing around the icons in the autofill section, so that the padding is the same 20dp on both sides. Bug: 922573 Change-Id: Ic949f73b587582e371576798ddf9f5c0cb5daf4d Reviewed-on: https://chromium-review.googlesource.com/c/1420760 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#624256} [modify] https://crrev.com/4081c99e3f4a12645a513c71d86e4653f49e2530/chrome/browser/resources/settings/autofill_page/autofill_page.html
,
Jan 18
(4 days ago)
,
Yesterday
(43 hours ago)
Able to reproduce the issue on chrome version #73.0.3672.0 using Ubuntu 17.10, Windows 10 and Mac OS 10.13.6 by following steps as per comment#0. Verified the fix on Mac 10.13.6, Ubuntu 17.10 and Windows 10 as per comment#0 on latest chrome version #73.0.3679.0. Attaching screenshots for reference. Observed that the spacing around the icons in the autofill section is the same on both sides. Hence, the fix is working as expected. Adding the verified labels. Thanks...!! |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by maxwalker@chromium.org
, Jan 16 (6 days ago)121 KB
121 KB View Download