New issue
Advanced search Search tips

Issue 922558 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 17
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression

Blocked on:
issue 922512



Sign in to add a comment

31.9%-60.6% regression in queueing_durations,thread_total_all_cpu_time_per_frame at 622421:622472

Project Member Reported by 42576172...@developer.gserviceaccount.com, Jan 16 (6 days ago)

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Jan 16 (6 days ago)

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=922558

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=f7d9ee60f4eaaabddc6a71f4de161047133609ce072086af237874c06925e84a


Bot(s) for this bug's original alert(s):

mac-10_12_laptop_low_end-perf
mac-10_13_laptop_high_end-perf

rendering.desktop - Benchmark documentation link:
  https://bit.ly/rendering-benchmarks
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Jan 16 (6 days ago)

Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jan 16 (6 days ago)

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/14b08714540000

All of the runs failed. The most common error (20/20 runs) was:
ReadValueError: Could not find values matching: {'story': u'smash_cat', 'histogram': u'queueing_durations'}

Comment 4 by sullivan@chromium.org, Jan 16 (6 days ago)

Blockedon: 922512
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Jan 16 (6 days ago)

Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Jan 16 (6 days ago)

Cc: neis@chromium.org
Owner: neis@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/14cdf714540000

Reland^3 "[turbofan] Use feedback when reducing global loads/stores." by neis@chromium.org
https://chromium.googlesource.com/v8/v8/+/8683116e64335a99ecc403c509587410db070cd1
queueing_durations: 1.521 → 2.162 (+0.6409)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Benchmark documentation link:
  https://bit.ly/rendering-benchmarks
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 17 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/073063d794eb537e549d415dc406f759b580ff7c

commit 073063d794eb537e549d415dc406f759b580ff7c
Author: Georg Neis <neis@chromium.org>
Date: Thu Jan 17 15:21:27 2019

Revert "Reland^3 "[turbofan] Use feedback when reducing global loads/stores.""

This reverts commit 8683116e64335a99ecc403c509587410db070cd1.

Reason for revert: There's a bug in the StoreGlobalIC that causes regressions in combination with this CL (observable in Chrome but
not in d8).

Original change's description:
> Reland^3 "[turbofan] Use feedback when reducing global loads/stores."
>
> This is a reland of 2d2c1374929c7ff41bed6526103ba6217009057a without
> changes. Offending chromium tests have been modified.
>
> Original change's description:
> > Reland^2 "[turbofan] Use feedback when reducing global loads/stores."
> >
> > This reverts commit ac85ab0a3d520a0c13b7e9224bf012cc4d9aa717. A
> > chromium test caused trouble and was taken care of in
> > https://chromium-review.googlesource.com/c/1384064.
> >
> > Original change's description:
> > > [turbofan] Use feedback when reducing global loads/stores.
> > >
> > > We already record the script context location or the property cell
> > > as feedback of the global load/store IC, so Turbofan doesn't need
> > > to do the lookups again.
> >
> > TBR=sigurds@chromium.org
> >
> > Change-Id: I58bcd9bceec2f9cf401f7b0fc4460a6da6cd0abc
> > Reviewed-on: https://chromium-review.googlesource.com/c/1386404
> > Commit-Queue: Georg Neis <neis@chromium.org>
> > Reviewed-by: Georg Neis <neis@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#58393}
>
> Change-Id: Ic6734201a6c45f2752488ab44b16859776802f51
> Reviewed-on: https://chromium-review.googlesource.com/c/1408252
> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
> Commit-Queue: Georg Neis <neis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#58769}

TBR=neis@chromium.org,sigurds@chromium.org,bmeurer@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:922545, chromium:922514,  chromium:922558 
Change-Id: I6e4c4c0fbc29a0f2a03972f1687242ae247ebfa8
Reviewed-on: https://chromium-review.googlesource.com/c/1417614
Commit-Queue: Georg Neis <neis@chromium.org>
Reviewed-by: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58891}
[modify] https://crrev.com/073063d794eb537e549d415dc406f759b580ff7c/src/compiler/js-native-context-specialization.cc
[modify] https://crrev.com/073063d794eb537e549d415dc406f759b580ff7c/src/compiler/js-native-context-specialization.h
[modify] https://crrev.com/073063d794eb537e549d415dc406f759b580ff7c/src/feedback-vector.cc
[modify] https://crrev.com/073063d794eb537e549d415dc406f759b580ff7c/src/feedback-vector.h
[modify] https://crrev.com/073063d794eb537e549d415dc406f759b580ff7c/src/ic/ic.cc

Comment 8 by neis@google.com, Jan 17 (5 days ago)

Status: Fixed (was: Assigned)

Sign in to add a comment