New issue
Advanced search Search tips

Issue 922512 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 922486
issue 922526
issue 922538
issue 922514
issue 922521
issue 922522
issue 922524
issue 922556
issue 922557
issue 922558
issue 922561
issue 922562



Sign in to add a comment

All pinpoint bisects failing in Get results phase

Project Member Reported by sullivan@chromium.org, Jan 16 (6 days ago)

Issue description

I see stacks like:

Traceback (most recent call last):
  File "/base/data/home/apps/s~chromeperf/pinpoint:clean-dtu-c329a12f.415436443363843331/dashboard/pinpoint/models/quest/execution.py", line 95, in Poll
    self._Poll()
  File "/base/data/home/apps/s~chromeperf/pinpoint:clean-dtu-c329a12f.415436443363843331/dashboard/pinpoint/models/quest/read_value.py", line 131, in _Poll
    raise ReadValueError('Could not find values matching: %s' % conditions)
ReadValueError: Could not find values matching: {'story': u'mix_blend_mode_animation_propagating_isolation', 'histogram': u'frame_times'}
 

Comment 1 by simonhatch@chromium.org, Jan 16 (6 days ago)

Owner: simonhatch@chromium.org

Comment 2 by simonhatch@chromium.org, Jan 16 (6 days ago)

Will take a look.

Comment 3 by sullivan@chromium.org, Jan 16 (6 days ago)

Blocking: 922514

Comment 4 by sullivan@chromium.org, Jan 16 (6 days ago)

Blocking: 922521

Comment 5 by sullivan@chromium.org, Jan 16 (6 days ago)

Blocking: 922522

Comment 6 by sullivan@chromium.org, Jan 16 (6 days ago)

Blocking: 922526

Comment 7 by sullivan@chromium.org, Jan 16 (6 days ago)

Blocking: 922538

Comment 8 by sullivan@chromium.org, Jan 16 (6 days ago)

Blocking: 922558

Comment 9 by simonhatch@chromium.org, Jan 16 (6 days ago)

So in all the cases I looked at, it looks like no stories were run.

It looks like a new version of Pinpoint was deployed really late last night. Cursory glance over the logs of version from before vs after, newer (failing) runs seem to also include a --story-tag-filter parameter.

I'll try rolling back Pinpoint as a first step.

Comment 10 by sullivan@chromium.org, Jan 16 (6 days ago)

Blocking: 922556

Comment 11 by sullivan@chromium.org, Jan 16 (6 days ago)

Blocking: 922557

Comment 12 by sullivan@chromium.org, Jan 16 (6 days ago)

Blocking: 922561

Comment 13 by sullivan@chromium.org, Jan 16 (6 days ago)

Blocking: 922524

Comment 14 by sullivan@chromium.org, Jan 16 (6 days ago)

Blocking: 922562

Comment 15 by simonhatch@chromium.org, Jan 16 (6 days ago)

Ok this is fixed, and I re-ran one as a test. Seems to be going: https://pinpoint-dot-chromeperf.appspot.com/job/17d0f7c0540000

I'll check up on it in a bit, and if it seems all good I'll rerun any others that are duped against this bug.

Comment 16 by simonhatch@chromium.org, Jan 16 (6 days ago)

Status: Fixed (was: Untriaged)
Going to call this fixed, latest runs are producing results. Have restarted all bisects duped against this.

Comment 17 by sullivan@chromium.org, Jan 16 (6 days ago)

Thanks!
Project Member

Comment 18 by bugdroid1@chromium.org, Jan 17 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/ff5a19a8ec57d97b5f26e7ff65d826cf4aa3b593

commit ff5a19a8ec57d97b5f26e7ff65d826cf4aa3b593
Author: Dave Tu <dtu@chromium.org>
Date: Thu Jan 17 12:06:15 2019

[pinpoint] Rename "tags" argument to "story_tags".

Name collision - there's already an argument named "tags".

Bug:  chromium:922512 
Change-Id: I9f318b873920e98f408298a8aee4eb6174a308ed
Reviewed-on: https://chromium-review.googlesource.com/c/1415726
Auto-Submit: Dave Tu <dtu@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/ff5a19a8ec57d97b5f26e7ff65d826cf4aa3b593/dashboard/dashboard/pinpoint/elements/jobs-page/new-job-fab.html
[modify] https://crrev.com/ff5a19a8ec57d97b5f26e7ff65d826cf4aa3b593/dashboard/dashboard/pinpoint/models/quest/run_telemetry_test_test.py
[modify] https://crrev.com/ff5a19a8ec57d97b5f26e7ff65d826cf4aa3b593/dashboard/dashboard/pinpoint/models/quest/run_telemetry_test.py

Project Member

Comment 19 by bugdroid1@chromium.org, Jan 17 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76bedcf61e2d8f2132330a2ad76afead666d6da7

commit 76bedcf61e2d8f2132330a2ad76afead666d6da7
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Thu Jan 17 13:30:17 2019

Roll src/third_party/catapult a9729f33472a..ff5a19a8ec57 (1 commits)

https://chromium.googlesource.com/catapult.git/+log/a9729f33472a..ff5a19a8ec57


git log a9729f33472a..ff5a19a8ec57 --date=short --no-merges --format='%ad %ae %s'
2019-01-17 dtu@chromium.org [pinpoint] Rename "tags" argument to "story_tags".


Created with:
  gclient setdep -r src/third_party/catapult@ff5a19a8ec57

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:922512 
TBR=sullivan@chromium.org

Change-Id: Ibc58c7b38a4ab7f5ccd88a574bc06deeb7037f0c
Reviewed-on: https://chromium-review.googlesource.com/c/1417282
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#623667}
[modify] https://crrev.com/76bedcf61e2d8f2132330a2ad76afead666d6da7/DEPS

Sign in to add a comment