All pinpoint bisects failing in Get results phase |
|||||||||||||
Issue description
I see stacks like:
Traceback (most recent call last):
File "/base/data/home/apps/s~chromeperf/pinpoint:clean-dtu-c329a12f.415436443363843331/dashboard/pinpoint/models/quest/execution.py", line 95, in Poll
self._Poll()
File "/base/data/home/apps/s~chromeperf/pinpoint:clean-dtu-c329a12f.415436443363843331/dashboard/pinpoint/models/quest/read_value.py", line 131, in _Poll
raise ReadValueError('Could not find values matching: %s' % conditions)
ReadValueError: Could not find values matching: {'story': u'mix_blend_mode_animation_propagating_isolation', 'histogram': u'frame_times'}
,
Jan 16
(6 days ago)
Will take a look.
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
So in all the cases I looked at, it looks like no stories were run. It looks like a new version of Pinpoint was deployed really late last night. Cursory glance over the logs of version from before vs after, newer (failing) runs seem to also include a --story-tag-filter parameter. I'll try rolling back Pinpoint as a first step.
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
Ok this is fixed, and I re-ran one as a test. Seems to be going: https://pinpoint-dot-chromeperf.appspot.com/job/17d0f7c0540000 I'll check up on it in a bit, and if it seems all good I'll rerun any others that are duped against this bug.
,
Jan 16
(6 days ago)
Going to call this fixed, latest runs are producing results. Have restarted all bisects duped against this.
,
Jan 16
(6 days ago)
Thanks!
,
Jan 17
(5 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/ff5a19a8ec57d97b5f26e7ff65d826cf4aa3b593 commit ff5a19a8ec57d97b5f26e7ff65d826cf4aa3b593 Author: Dave Tu <dtu@chromium.org> Date: Thu Jan 17 12:06:15 2019 [pinpoint] Rename "tags" argument to "story_tags". Name collision - there's already an argument named "tags". Bug: chromium:922512 Change-Id: I9f318b873920e98f408298a8aee4eb6174a308ed Reviewed-on: https://chromium-review.googlesource.com/c/1415726 Auto-Submit: Dave Tu <dtu@chromium.org> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> [modify] https://crrev.com/ff5a19a8ec57d97b5f26e7ff65d826cf4aa3b593/dashboard/dashboard/pinpoint/elements/jobs-page/new-job-fab.html [modify] https://crrev.com/ff5a19a8ec57d97b5f26e7ff65d826cf4aa3b593/dashboard/dashboard/pinpoint/models/quest/run_telemetry_test_test.py [modify] https://crrev.com/ff5a19a8ec57d97b5f26e7ff65d826cf4aa3b593/dashboard/dashboard/pinpoint/models/quest/run_telemetry_test.py
,
Jan 17
(5 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/76bedcf61e2d8f2132330a2ad76afead666d6da7 commit 76bedcf61e2d8f2132330a2ad76afead666d6da7 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Jan 17 13:30:17 2019 Roll src/third_party/catapult a9729f33472a..ff5a19a8ec57 (1 commits) https://chromium.googlesource.com/catapult.git/+log/a9729f33472a..ff5a19a8ec57 git log a9729f33472a..ff5a19a8ec57 --date=short --no-merges --format='%ad %ae %s' 2019-01-17 dtu@chromium.org [pinpoint] Rename "tags" argument to "story_tags". Created with: gclient setdep -r src/third_party/catapult@ff5a19a8ec57 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:922512 TBR=sullivan@chromium.org Change-Id: Ibc58c7b38a4ab7f5ccd88a574bc06deeb7037f0c Reviewed-on: https://chromium-review.googlesource.com/c/1417282 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#623667} [modify] https://crrev.com/76bedcf61e2d8f2132330a2ad76afead666d6da7/DEPS |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by simonhatch@chromium.org
, Jan 16 (6 days ago)