The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d56fb33888e3fc11a3ed45ecd8503253f3a01d0

commit 6d56fb33888e3fc11a3ed45ecd8503253f3a01d0
Author: Mason Freed <masonfreed@chromium.org>
Date: Wed Jan 16 19:13:31 2019

Marking synthetic-pinch-zoom-gesture-touchscreen-desktop.html as flaky

TBR=masonfreed@chromium.org
NOTRY=true

Bug: 922508
Change-Id: I66b5d5d3865456d5489884566c291629c1832884
Reviewed-on: https://chromium-review.googlesource.com/c/1415632
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623320}
[modify] https://crrev.com/6d56fb33888e3fc11a3ed45ecd8503253f3a01d0/third_party/blink/web_tests/TestExpectations

While the flakes started with the identified CL, I think this is a matter of exposing some latent flakiness in the test. It looks like we're missing a waitForCompositorCommit in the desktop cases.

Ok, sounds good. Let me know if you need any help debugging.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ac054b9379bf11b338030c2382535adc8791d3d

commit 7ac054b9379bf11b338030c2382535adc8791d3d
Author: Ian Clelland <iclelland@chromium.org>
Date: Wed Jan 16 22:45:40 2019

Mark virtual/threaded/synthetic_gestures/synthetic-pinch-zoom-gesture-touchpad-zoom-in-slow.html as flaky on Linux

Bug: 922508
Change-Id: I73fb2fe9672bdcb2594a6ec41991c721d7a73983
Reviewed-on: https://chromium-review.googlesource.com/c/1415579
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Kevin McNee <mcnee@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623414}
[modify] https://crrev.com/7ac054b9379bf11b338030c2382535adc8791d3d/third_party/blink/web_tests/TestExpectations

It's crashing on Mac10.13 Tests (dbg).

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/8322

STDERR: [75219:775:0116/123558.623518:FATAL:synthetic_gesture_target_base.cc(170)] Check failed: false. 
STDERR: 0   libbase.dylib                       0x0000000113c4d5c7 base::debug::StackTrace::StackTrace(unsigned long) + 87
STDERR: 1   libbase.dylib                       0x0000000113c4d67d base::debug::StackTrace::StackTrace(unsigned long) + 29
STDERR: 2   libbase.dylib                       0x0000000113934ef5 base::debug::StackTrace::StackTrace() + 37
STDERR: 3   libbase.dylib                       0x000000011397b0ce logging::LogMessage::~LogMessage() + 142
STDERR: 4   libbase.dylib                       0x0000000113979ec5 logging::LogMessage::~LogMessage() + 21
STDERR: 5   libcontent.dylib                    0x000000011af27e83 content::SyntheticGestureTargetBase::GetMinScalingSpanInDips() const + 115
STDERR: 6   libcontent.dylib                    0x000000011af320f4 content::SyntheticTouchscreenPinchGesture::SetupCoordinatesAndStopTime(content::SyntheticGestureTarget*) + 148
STDERR: 7   libcontent.dylib                    0x000000011af31e8c content::SyntheticTouchscreenPinchGesture::ForwardTouchInputEvents(base::TimeTicks const&, content::SyntheticGestureTarget*) + 188
STDERR: 8   libcontent.dylib                    0x000000011af31d5f content::SyntheticTouchscreenPinchGesture::ForwardInputEvents(base::TimeTicks const&, content::SyntheticGestureTarget*) + 447
STDERR: 9   libcontent.dylib                    0x000000011af29c81 content::SyntheticPinchGesture::ForwardInputEvents(base::TimeTicks const&, content::SyntheticGestureTarget*) + 705
STDERR: 10  libcontent.dylib                    0x000000011af21e34 content::SyntheticGestureController::DispatchNextEvent(base::TimeTicks) + 532
STDERR: 11  libcontent.dylib                    0x000000011af261d8 _ZZN7content26SyntheticGestureController10StartTimerEbENK3$_0clEN4base7WeakPtrIS0_EE + 72
STDERR: 12  libcontent.dylib                    0x000000011af2614d _ZN4base8internal13FunctorTraitsIZN7content26SyntheticGestureController10StartTimerEbE3$_0vE6InvokeIRKS4_JRKNS_7WeakPtrIS3_EEEEEvOT_DpOT0_ + 77
STDERR: 13  libcontent.dylib                    0x000000011af26082 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKZN7content26SyntheticGestureController10StartTimerEbE3$_0JRKNS_7WeakPtrIS5_EEEEEvOT_DpOT0_ + 50
STDERR: 14  libcontent.dylib                    0x000000011af26042 _ZN4base8internal7InvokerINS0_9BindStateIZN7content26SyntheticGestureController10StartTimerEbE3$_0JNS_7WeakPtrIS4_EEEEEFvvEE7RunImplIRKS5_RKNSt3__15tupleIJS7_EEEJLm0EEEEvOT_OT0_NSE_16integer_sequenceImJXspT1_EEEE + 66
STDERR: 15  libcontent.dylib                    0x000000011af25f5c _ZN4base8internal7InvokerINS0_9BindStateIZN7content26SyntheticGestureController10StartTimerEbE3$_0JNS_7WeakPtrIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE + 44
STDERR: 16  libbase.dylib                       0x00000001138f114d base::RepeatingCallback<void ()>::Run() const & + 61
STDERR: 17  libbase.dylib                       0x0000000113baff7e base::RepeatingTimer::RunUserTask() + 110
STDERR: 18  libbase.dylib                       0x0000000113baf504 base::internal::TimerBase::RunScheduledTask() + 228
STDERR: 19  libbase.dylib                       0x0000000113baf3a9 base::internal::BaseTimerTaskInternal::Run() + 73

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17b48d789ac6ffcdcf4340dd11c2ed56ab19fd48

commit 17b48d789ac6ffcdcf4340dd11c2ed56ab19fd48
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Thu Jan 17 02:14:33 2019

Mark virtual/threaded/synthetic_gestures/synthetic-pinch-zoom-gesture-touchpad-zoom-in-slow.html as flaky

It's failing on Mac10.13 Tests (dbg) bot too.

TBR=mcnee@chromium.org,masonfreed@chromium.org

No-Try: true
Bug: 922508
Change-Id: I3e0748250a9002f1854247aa4962b11f0a40671a
Reviewed-on: https://chromium-review.googlesource.com/c/1415233
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623514}
[modify] https://crrev.com/17b48d789ac6ffcdcf4340dd11c2ed56ab19fd48/third_party/blink/web_tests/TestExpectations

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c4b9e11bd4c51f684590a29f9415d6641fdd46b

commit 9c4b9e11bd4c51f684590a29f9415d6641fdd46b
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Thu Jan 17 04:32:55 2019

Mark virtual/threaded/synthetic_gestures/synthetic-pinch-zoom-gesture-touchscreen-desktop.html as Crash

This reverts https://chromium-review.googlesource.com/c/chromium/src/+/1415233
which marked a wrong test, and mark
virtual/threaded/synthetic_gestures/synthetic-pinch-zoom-gesture-touchscreen-desktop.html
as Crash because it's failing on Mac10.13 Tests (dbg) bot.

TBR=mcnee@chromium.org,masonfreed@chromium.org

No-Try: true
Bug: 922508
Change-Id: Ib40689bd9d0498788d83ae12c92fa6966a44c2d7
Reviewed-on: https://chromium-review.googlesource.com/c/1415058
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623576}
[modify] https://crrev.com/9c4b9e11bd4c51f684590a29f9415d6641fdd46b/third_party/blink/web_tests/TestExpectations

The crash looks like a simple case of adding an override for GetMinScalingSpanInDips to the Mac specific class. We don't support touch on Mac but synthetic gestures should work there too.

Re c#11: In TestExpectations, the Mac case was being skipped, but got commented out. I'm cleaning up the TestExpectations for these tests here: https://chromium-review.googlesource.com/c/chromium/src/+/1418522

In any case, I have a WIP CL that does add the necessary override: https://chromium-review.googlesource.com/c/chromium/src/+/1422578

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08aed290f42041ab29fc82ef6e127c33e2871b47

commit 08aed290f42041ab29fc82ef6e127c33e2871b47
Author: Kevin McNee <mcnee@chromium.org>
Date: Mon Jan 21 18:02:07 2019

Address flaky desktop touchscreen synthetic pinch zoom gesture tests

The lenient versions of these tests were missing a call to
waitForCompositorCommit after the gesture which the full versions of
the tests have.

We also clean up the TestExpectations for these synthetic_gestures tests
as some of the entries appear to no longer be an issue.

Bug: 922508,  787615 , 891427, 882975
Change-Id: Idf084b3651e74bbbfc337a73ba8223aa8db8d3a3
Reviewed-on: https://chromium-review.googlesource.com/c/1418522
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624613}
[modify] https://crrev.com/08aed290f42041ab29fc82ef6e127c33e2871b47/third_party/blink/web_tests/TestExpectations
[modify] https://crrev.com/08aed290f42041ab29fc82ef6e127c33e2871b47/third_party/blink/web_tests/virtual/threaded/synthetic_gestures/synthetic-pinch-zoom-gesture.js