New issue
Advanced search Search tips

Issue 922501 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Account image is not rounded in TableViewAccountCell

Project Member Reported by jlebel@chromium.org, Jan 16 (6 days ago)

Issue description

Sometimes the account image is not rounded in the TableViewAccountCell.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 16 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15e8f2a92929527aa96b6d5aa7374a67c5f01d70

commit 15e8f2a92929527aa96b6d5aa7374a67c5f01d70
Author: Jérôme Lebel <jlebel@chromium.org>
Date: Wed Jan 16 16:42:52 2019

[iOS] Fixing rounded image in TableViewAccountCell

The corner radius of |_imageView| should always be set to
kHorizontalImageFixedSize / 2.0f.

Also moving all the subviews attributes to -[TableViewAccountItem
addSubviews].

Bug:  922501 
Change-Id: Ib3fb2ca61038db12deab2edca1f48d049017b9db
Reviewed-on: https://chromium-review.googlesource.com/c/1412356
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623258}
[modify] https://crrev.com/15e8f2a92929527aa96b6d5aa7374a67c5f01d70/ios/chrome/browser/ui/authentication/cells/table_view_account_item.mm

Comment 2 by jlebel@chromium.org, Jan 16 (6 days ago)

Status: Fixed (was: Started)

Sign in to add a comment