New issue
Advanced search Search tips

Issue 922495 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 18
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

18.5%-∞% regression in console:error:all,timeToFirstContentfulPaint,timeToFirstPaint at 622411:622693

Project Member Reported by 42576172...@developer.gserviceaccount.com, Jan 16 (6 days ago)

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Jan 16 (6 days ago)

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=922495

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=6ec158ddbb486a9dab011ad705614f18ebbd40a335d9421b1772b3cc0d1b68ed


Bot(s) for this bug's original alert(s):

Android Nexus5 Perf
Android Nexus5X WebView Perf
Android Nexus6 WebView Perf
android-nexus5x-perf

system_health.common_mobile - Benchmark documentation link:
  https://bit.ly/system-health-benchmarks
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Jan 16 (6 days ago)

Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jan 17 (6 days ago)

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/12fa70dc540000

All of the runs failed. The most common error (20/20 runs) was:
ReadValueError: Could not find values matching: {'story': u'load:tools:docs', 'tir_label': u'load_tools', 'histogram': u'console:error:all'}
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Jan 17 (6 days ago)

Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Jan 18 (4 days ago)

Cc: drott@chromium.org
Owner: drott@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/16bcc044540000

Enable unique font matching matching by default by drott@chromium.org
https://chromium.googlesource.com/chromium/src/+/2e8e7c130cbb432732e973fd8c266a0608727b5f
console:error:all: 0 → 2 (+2)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Benchmark documentation link:
  https://bit.ly/system-health-benchmarks
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Jan 18 (4 days ago)

Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Jan 18 (4 days ago)

Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, Jan 18 (4 days ago)

Project Member

Comment 9 by bugdroid1@chromium.org, Jan 18 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09e747504f7caf471e94acc4916864790517e40c

commit 09e747504f7caf471e94acc4916864790517e40c
Author: Dominik Röttsches <drott@chromium.org>
Date: Fri Jan 18 14:37:47 2019

Revert "Reland "Enable unique font matching matching by default""

This reverts commit 1d366d59cf85b3013d0e3f4a9ee9edb98b99a49f.

Reason for revert: 
* Preliminary Windows font table lookup build times look too high
* Time to first paint affected on some lower end Android tests 

Original change's description:
> Reland "Enable unique font matching matching by default"
> 
> This reverts commit f6c717eb8b60f311b6357b3ddace4c79b1a2e64e.
> 
> Reason for revert: Crash has been addressed in 
> https://chromium-review.googlesource.com/c/chromium/src/+/1414852
> 
> Original change's description:
> > Revert "Enable unique font matching matching by default"
> > 
> > This reverts commit 2e8e7c130cbb432732e973fd8c266a0608727b5f.
> > 
> > Reason for revert: Crashes observed in Windows Canary
> > 
> > Bug: 922183
> > 
> > Original change's description:
> > > Enable unique font matching matching by default
> > > 
> > > Now that all implementations for Android, Windows, Linux/CrOS and Mac
> > > are in place, enable the feature globally. Chrome will match fonts
> > > references in @font-face { src: local(<font-name>) } correctly by
> > > postscript name or full font name. This addresses a long standing,
> > > highly starred font matching issue in Chrome.
> > > 
> > > Bug: 828317, 627143,  921029 
> > > Change-Id: I348855fdca817a4cd279f4d938e6d5ffe91ee004
> > > Reviewed-on: https://chromium-review.googlesource.com/c/1400695
> > > Commit-Queue: Dominik Röttsches <drott@chromium.org>
> > > Reviewed-by: Avi Drissman <avi@chromium.org>
> > > Reviewed-by: Emil A Eklund <eae@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#622456}
> > 
> > TBR=avi@chromium.org,eae@chromium.org,drott@chromium.org
> > 
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> > 
> > Bug: 828317, 627143,  921029 
> > Change-Id: I6a89f36923abb7d87de712c9ac0852da06a66d37
> > Reviewed-on: https://chromium-review.googlesource.com/c/1412824
> > Reviewed-by: Dominik Röttsches <drott@chromium.org>
> > Commit-Queue: Dominik Röttsches <drott@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#622898}
> 
> TBR=avi@chromium.org,eae@chromium.org,drott@chromium.org
> 
> Change-Id: I915e1bb20ee51325befa5ef7eab07f78eaa8c974
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 922183, 828317, 627143,  921029 , 922183
> Reviewed-on: https://chromium-review.googlesource.com/c/1413603
> Reviewed-by: Dominik Röttsches <drott@chromium.org>
> Commit-Queue: Dominik Röttsches <drott@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#623199}

TBR=avi@chromium.org,eae@chromium.org,drott@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 922183, 828317, 627143,  921029 , 923245,  922495 , 922941
Change-Id: I27efa4f06148c2fc58d7feb5f15f48623713a570
Reviewed-on: https://chromium-review.googlesource.com/c/1421099
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624117}
[modify] https://crrev.com/09e747504f7caf471e94acc4916864790517e40c/content/public/common/content_features.cc
[modify] https://crrev.com/09e747504f7caf471e94acc4916864790517e40c/third_party/blink/web_tests/NeverFixTests
[modify] https://crrev.com/09e747504f7caf471e94acc4916864790517e40c/third_party/blink/web_tests/fast/css/font-face-character-fallback.html
[modify] https://crrev.com/09e747504f7caf471e94acc4916864790517e40c/third_party/blink/web_tests/fast/css/font-face-descending-unicode-range.html
[modify] https://crrev.com/09e747504f7caf471e94acc4916864790517e40c/third_party/blink/web_tests/fast/css/font-face-download-error.html
[modify] https://crrev.com/09e747504f7caf471e94acc4916864790517e40c/third_party/blink/web_tests/fast/css/font-face-in-media-rule.html
[modify] https://crrev.com/09e747504f7caf471e94acc4916864790517e40c/third_party/blink/web_tests/fast/css/font-face-multiple-ranges-for-unicode-range.html
[modify] https://crrev.com/09e747504f7caf471e94acc4916864790517e40c/third_party/blink/web_tests/fast/css/font-face-unicode-range-monospace.html
[modify] https://crrev.com/09e747504f7caf471e94acc4916864790517e40c/third_party/blink/web_tests/fast/css/fontfaceset-add-remove.html
[modify] https://crrev.com/09e747504f7caf471e94acc4916864790517e40c/third_party/blink/web_tests/fast/css/fontfaceset-download-error.html
[modify] https://crrev.com/09e747504f7caf471e94acc4916864790517e40c/third_party/blink/web_tests/fast/css/fontfaceset-multiple-faces.html
[modify] https://crrev.com/09e747504f7caf471e94acc4916864790517e40c/third_party/blink/web_tests/fast/forms/select-popup/popup-menu-font-face.html
[modify] https://crrev.com/09e747504f7caf471e94acc4916864790517e40c/third_party/blink/web_tests/fast/inline/vertical-align-with-fallback-fonts.html
[modify] https://crrev.com/09e747504f7caf471e94acc4916864790517e40c/third_party/blink/web_tests/fast/text/capitalize-boundaries.html
[delete] https://crrev.com/16c9e690685282e3e5d61b393347352b9507e6cd/third_party/blink/web_tests/fast/text/unique-vs-family-match.html
[modify] https://crrev.com/09e747504f7caf471e94acc4916864790517e40c/third_party/blink/web_tests/inspector-protocol/layout-fonts/unicode-range-order.js
[delete] https://crrev.com/16c9e690685282e3e5d61b393347352b9507e6cd/third_party/blink/web_tests/platform/mac-mac10.10/fast/text/unique-vs-family-match-expected.png
[delete] https://crrev.com/16c9e690685282e3e5d61b393347352b9507e6cd/third_party/blink/web_tests/platform/mac-mac10.12/fast/text/unique-vs-family-match-expected.png
[delete] https://crrev.com/16c9e690685282e3e5d61b393347352b9507e6cd/third_party/blink/web_tests/platform/mac/fast/text/unique-vs-family-match-expected.png

Comment 10 by drott@chromium.org, Jan 18 (4 days ago)

Status: Fixed (was: Assigned)
Project Member

Comment 11 by 42576172...@developer.gserviceaccount.com, Jan 19 (3 days ago)

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/17c7c072540000

The swarming task expired. The bots are likely overloaded, dead, or misconfigured.
Project Member

Comment 12 by 42576172...@developer.gserviceaccount.com, Jan 19 (3 days ago)

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/155d42d8540000

The swarming task expired. The bots are likely overloaded, dead, or misconfigured.
Project Member

Comment 13 by 42576172...@developer.gserviceaccount.com, Jan 19 (3 days ago)

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/13d62362540000

The swarming task expired. The bots are likely overloaded, dead, or misconfigured.

Sign in to add a comment