Add API to replace AccountTrackerService::{IsMigrationSupported,SetMigrationDone,GetMigrationState} |
||||||||
Issue descriptionThose are legacy method and should eventually be removed when the delegate is moved into the component. Until then, we need to add them to IdentityManager bool IdentityManager::IsAccountIdMigrationSupported() const; void IdentityManager::SetAccountIdMigrationDone(); IdentityMananger::AccountIdMigrationState IdentityManager::GetAccountIdMigrationState() const;
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
,
Jan 17
(6 days ago)
,
Jan 17
(6 days ago)
,
Jan 17
(6 days ago)
,
Jan 17
(5 days ago)
,
Jan 18
(4 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d291b28fc62a52a0600837c6793be4fb5cce1247 commit d291b28fc62a52a0600837c6793be4fb5cce1247 Author: Mario Sanchez Prada <mario@igalia.com> Date: Fri Jan 18 17:38:39 2019 Add API to replace ATS::{IsMigrationSupported,GetMigrationState} Add the following two legacy methods to IdentityManager that to help with the migration to the Identity service: - IsAccountIdMigrationSupported() - GetAccountIdMigrationState() Bug: 922477 Change-Id: Ic55a21fa70231b6c85227888d5a6a153b886b647 Reviewed-on: https://chromium-review.googlesource.com/c/1418052 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#624185} [modify] https://crrev.com/d291b28fc62a52a0600837c6793be4fb5cce1247/services/identity/public/cpp/identity_manager.cc [modify] https://crrev.com/d291b28fc62a52a0600837c6793be4fb5cce1247/services/identity/public/cpp/identity_manager.h [modify] https://crrev.com/d291b28fc62a52a0600837c6793be4fb5cce1247/services/identity/public/cpp/identity_manager_unittest.cc
,
Jan 18
(4 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9851d6a2e8fb586f7391a4ad8e5a96d7f04cd0a7 commit 9851d6a2e8fb586f7391a4ad8e5a96d7f04cd0a7 Author: Mario Sanchez Prada <mario@igalia.com> Date: Fri Jan 18 18:00:06 2019 Add API to replace AccountTrackerService::SetMigrationDone Add the a legacy method IdentityManager::SetAccountIdMigrationDone() to cover those uses cases without depending on AccountTrackerService. Bug: 922477 Change-Id: I57b54593552d2806494b97ca40ef171c0b684d50 Reviewed-on: https://chromium-review.googlesource.com/c/1420919 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#624195} [modify] https://crrev.com/9851d6a2e8fb586f7391a4ad8e5a96d7f04cd0a7/services/identity/public/cpp/identity_manager.cc [modify] https://crrev.com/9851d6a2e8fb586f7391a4ad8e5a96d7f04cd0a7/services/identity/public/cpp/identity_manager.h
,
Jan 18
(4 days ago)
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by sdefresne@chromium.org
, Jan 16 (6 days ago)