Add API to replace AccountTrackerService::{SetIsChildAccount,SetIsAdvancedProtectionAccount} |
|||||||||||
Issue description
This should instead use a method from AccountsMutator:
// Updates the information about account identified by |account_id|.
bool AccountsMutator::UpdateAccountInfo(
const std::string& account_id,
...);
The exact parameters passed to this method should be identified. They may be base::Optional<bool> or a tri-state enum (|unset|, |set_true|, |set_false|).
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
,
Jan 17
(6 days ago)
,
Jan 17
(6 days ago)
,
Jan 17
(6 days ago)
,
Jan 17
(5 days ago)
,
Jan 17
(5 days ago)
CL building here: https://chromium-review.googlesource.com/c/chromium/src/+/1417174
,
Jan 18
(4 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/341c99a2593c16cb9b5c2039ece642b8c5b8f7cc commit 341c99a2593c16cb9b5c2039ece642b8c5b8f7cc Author: Mario Sanchez Prada <mario@igalia.com> Date: Fri Jan 18 17:18:25 2019 Add API to replace ATS::{SetIsChildAccount,SetIsAdvancedProtectionAccount} Add AccountsMutator::UpdateAccountInfo() to allow changing |is_child_account| and/or |is_under_advanced_protection| for a given |account_id|, and provide a new unit test to cover this new API. Bug: 922474 Change-Id: I6d549b50b0947964e111f38d0d504936779cbbb2 Reviewed-on: https://chromium-review.googlesource.com/c/1417174 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#624173} [modify] https://crrev.com/341c99a2593c16cb9b5c2039ece642b8c5b8f7cc/services/identity/public/cpp/accounts_mutator.h [modify] https://crrev.com/341c99a2593c16cb9b5c2039ece642b8c5b8f7cc/services/identity/public/cpp/accounts_mutator_impl.cc [modify] https://crrev.com/341c99a2593c16cb9b5c2039ece642b8c5b8f7cc/services/identity/public/cpp/accounts_mutator_impl.h [modify] https://crrev.com/341c99a2593c16cb9b5c2039ece642b8c5b8f7cc/services/identity/public/cpp/accounts_mutator_unittest.cc
,
Jan 18
(4 days ago)
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by sdefresne@chromium.org
, Jan 16 (6 days ago)