New issue
Advanced search Search tips

Issue 922473 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Today
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug


Sign in to add a comment

Add legacy API to replace AccountTrackerService::SeedAccountInfo

Project Member Reported by sdefresne@chromium.org, Jan 16 (6 days ago)

Issue description

The API will be removed when the delegate is moved inside the component. Until then, we are going to expose the method as the following:

  std::string IdentityManager::LegacySeedAccountInfo(
      const std::string& gaia,
      const std::string& email);

 

Comment 1 by dxie@google.com, Jan 16 (6 days ago)

Blocking: 922743

Comment 2 by dxie@google.com, Jan 16 (6 days ago)

Blocking: 922747

Comment 3 by dxie@google.com, Jan 16 (6 days ago)

Blocking: 922752

Comment 4 by dxie@google.com, Jan 16 (6 days ago)

Blocking: 922755

Comment 5 by dxie@google.com, Jan 16 (6 days ago)

Blocking: 922756

Comment 6 by dxie@google.com, Jan 16 (6 days ago)

Blocking: 922759

Comment 7 by dxie@google.com, Jan 17 (6 days ago)

Blocking: 922770

Comment 8 by dxie@google.com, Jan 17 (6 days ago)

Blocking: 922773

Comment 9 by dxie@google.com, Jan 17 (6 days ago)

Blocking: 922776

Comment 10 by dxie@google.com, Jan 17 (6 days ago)

Blocking: 922777

Comment 11 by dxie@google.com, Jan 17 (6 days ago)

Blocking: 922789

Comment 12 by dxie@google.com, Jan 17 (6 days ago)

Blocking: 922790

Comment 13 by dxie@google.com, Jan 17 (6 days ago)

Blocking: 922791

Comment 14 by dxie@google.com, Jan 17 (6 days ago)

Blocking: 922794

Comment 15 by dxie@google.com, Jan 17 (6 days ago)

Blocking: 922795

Comment 16 by dxie@google.com, Jan 17 (6 days ago)

Blocking: 922797

Comment 17 by dxie@google.com, Jan 17 (6 days ago)

Blocking: 922801

Comment 18 by dxie@google.com, Jan 17 (6 days ago)

Blocking: 922802

Comment 19 by je_julie.kim@chromium.org, Jan 17 (6 days ago)

Owner: je_julie.kim@chromium.org
Status: Started (was: Available)
Project Member

Comment 21 by bugdroid1@chromium.org, Yesterday (28 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76987c17590e8b6cb4a71092c1d0e8c380e39f7d

commit 76987c17590e8b6cb4a71092c1d0e8c380e39f7d
Author: Julie Jeongeun Kim <jkim@igalia.com>
Date: Tue Jan 22 01:28:24 2019

[s13n] Add LegacySeedAccountInfo to IdentityManager

This CL adds LegacySeedAccountInfo to IdentityManager to replace
AccountTrackerService::SeedAccountInfo in production code.

Test: IdentityManagerTest.LegacySeedAccountInfo
Bug:  922473 
Change-Id: Ie0107dd36db6e53da851d8b1f19606f2e712f704
Reviewed-on: https://chromium-review.googlesource.com/c/1416792
Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624711}
[modify] https://crrev.com/76987c17590e8b6cb4a71092c1d0e8c380e39f7d/services/identity/public/cpp/identity_manager.cc
[modify] https://crrev.com/76987c17590e8b6cb4a71092c1d0e8c380e39f7d/services/identity/public/cpp/identity_manager.h
[modify] https://crrev.com/76987c17590e8b6cb4a71092c1d0e8c380e39f7d/services/identity/public/cpp/identity_manager_unittest.cc

Comment 22 by je_julie.kim@chromium.org, Today (3 hours ago)

Status: Fixed (was: Started)

Sign in to add a comment