New issue
Advanced search Search tips

Issue 922471 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug


Sign in to add a comment

Add legacy API to replace AccountTrackerService::PickAccountIdForAccount

Project Member Reported by sdefresne@chromium.org, Jan 16 (6 days ago)

Issue description

The API will be removed when the delegate is moved inside the component. Until then, we are going to expose the method as the following:

  std::string IdentityManager::LegacyPickAccountIdForAccount(
      const std::string& gaia,
      const std::string& email);

 

Comment 1 by sdefresne@chromium.org, Jan 16 (6 days ago)

Blocking: 922472

Comment 2 by dxie@google.com, Jan 16 (6 days ago)

Blocking: 922749

Comment 3 by dxie@google.com, Jan 16 (6 days ago)

Blocking: 922759

Comment 4 by dxie@google.com, Jan 16 (6 days ago)

Blocking: 922767

Comment 5 by dxie@google.com, Jan 16 (6 days ago)

Blocking: 922768

Comment 6 by dxie@google.com, Jan 17 (6 days ago)

Blocking: 922769

Comment 7 by dxie@google.com, Jan 17 (6 days ago)

Blocking: 922770

Comment 8 by dxie@google.com, Jan 17 (6 days ago)

Blocking: 922771

Comment 9 by dxie@google.com, Jan 17 (6 days ago)

Blocking: 922772

Comment 10 by dxie@google.com, Jan 17 (6 days ago)

Blocking: 922798

Comment 11 by dxie@google.com, Jan 17 (6 days ago)

Blockedon: 922799

Comment 12 by dxie@google.com, Jan 17 (6 days ago)

Blocking: 922800

Comment 13 by gyuyo...@igalia.com, Jan 17 (5 days ago)

Owner: gyuyo...@igalia.com
I'd like to take over this bug.

Comment 14 by gyuyo...@igalia.com, Jan 18 (5 days ago)

Status: Started (was: Available)
Project Member

Comment 15 by bugdroid1@chromium.org, Yesterday (41 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d2c39fd6cfbc2653f7a38b2a2ea7bb5cf1f1fa0

commit 7d2c39fd6cfbc2653f7a38b2a2ea7bb5cf1f1fa0
Author: Gyuyoung Kim <gyuyoung@igalia.com>
Date: Mon Jan 21 13:01:33 2019

s13n: Add legacy API to replace AccountTrackerService::PickAccountIdForAccount

The AccountTrackerService::PickAccountIdForAccount will be removed when the delegate
is moved inside the component. Until then, we expose the method as
IdentityManager::LegacyPickAccountIdForAccount.

TEST: IdentityManagerTest.TestLegacyPickAccountIdForAccount
Bug: 922471
Change-Id: I9cf97b9899b00868baf7439b50bc8f1b39a8c8c6
Reviewed-on: https://chromium-review.googlesource.com/c/1417402
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624572}
[modify] https://crrev.com/7d2c39fd6cfbc2653f7a38b2a2ea7bb5cf1f1fa0/services/identity/public/cpp/identity_manager.cc
[modify] https://crrev.com/7d2c39fd6cfbc2653f7a38b2a2ea7bb5cf1f1fa0/services/identity/public/cpp/identity_manager.h
[modify] https://crrev.com/7d2c39fd6cfbc2653f7a38b2a2ea7bb5cf1f1fa0/services/identity/public/cpp/identity_manager_unittest.cc

Sign in to add a comment