New issue
Advanced search Search tips

Issue 922470 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Today
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug


Sign in to add a comment

Add missing API to replace AccountTrackerService::Observer::OnAccountRemoved

Project Member Reported by sdefresne@chromium.org, Jan 16 (6 days ago)

Issue description

The API would probably be the following:

  void IdentityManager::Observer::OnAccountRemovedWithInfo(
      const AccountInfo& account_info);

 

 

Comment 1 by dxie@google.com, Jan 16 (6 days ago)

Blocking: 922745

Comment 2 by dxie@google.com, Jan 16 (6 days ago)

Blocking: 922746

Comment 3 by dxie@google.com, Jan 16 (6 days ago)

Blocking: 922750

Comment 4 by dxie@google.com, Jan 16 (6 days ago)

Blocking: 922751

Comment 5 by dxie@google.com, Jan 16 (6 days ago)

Blocking: 922753

Comment 6 by dxie@google.com, Jan 16 (6 days ago)

Blocking: 922754

Comment 7 by dxie@google.com, Jan 16 (6 days ago)

Blocking: 922761

Comment 8 by dxie@google.com, Jan 16 (6 days ago)

Blocking: 922762

Comment 9 by dxie@google.com, Jan 17 (6 days ago)

Blocking: 922778

Comment 10 by dxie@google.com, Jan 17 (6 days ago)

Blocking: 922779

Comment 11 by dxie@google.com, Jan 17 (6 days ago)

Blockedon: 922781

Comment 12 by dxie@google.com, Jan 17 (6 days ago)

Blocking: 922782

Comment 13 by dxie@google.com, Jan 17 (6 days ago)

Blocking: 922785

Comment 14 by dxie@google.com, Jan 17 (6 days ago)

Blocking: 922786

Comment 15 by dxie@google.com, Jan 17 (6 days ago)

Blocking: 922787

Comment 16 by dxie@google.com, Jan 17 (6 days ago)

Blockedon: 922788

Comment 17 by gyuyo...@igalia.com, Jan 18 (5 days ago)

Owner: gyuyo...@igalia.com
Status: Started (was: Available)
I'd like to take this bug.
Project Member

Comment 19 by bugdroid1@chromium.org, Yesterday (43 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0afd4b2fbdb0c1de179fab86ab68b67dcbcadfc7

commit 0afd4b2fbdb0c1de179fab86ab68b67dcbcadfc7
Author: Gyuyoung Kim <gyuyoung@igalia.com>
Date: Mon Jan 21 11:08:40 2019

s13n: Add a new API to replace AccountTrackerService::Observer::OnAccountRemoved

As a step to replace AccountTrackerService with IdentityManager, this CL adds a new API
to replace AccountTrackerService::Observer::OnAccountRemoved.

TEST: IdentityManagerTest.TestOnAccountRemovedWithInfoCallback
Bug:  922470 
Change-Id: I911604aacd1001f2165afbae7380efefead4be4c
Reviewed-on: https://chromium-review.googlesource.com/c/1420507
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#624554}
[modify] https://crrev.com/0afd4b2fbdb0c1de179fab86ab68b67dcbcadfc7/services/identity/public/cpp/identity_manager.cc
[modify] https://crrev.com/0afd4b2fbdb0c1de179fab86ab68b67dcbcadfc7/services/identity/public/cpp/identity_manager.h
[modify] https://crrev.com/0afd4b2fbdb0c1de179fab86ab68b67dcbcadfc7/services/identity/public/cpp/identity_manager_unittest.cc

Comment 20 by gyuyo...@igalia.com, Today (21 hours ago)

Status: Fixed (was: Started)

Sign in to add a comment