New issue
Advanced search Search tips

Issue 922469 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Yesterday
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug


Sign in to add a comment

Add missing API to replace AccountTrackerService::Observer::OnAccountUpdated

Project Member Reported by sdefresne@chromium.org, Jan 16 (6 days ago)

Issue description

The API would probably be the following:

  void IdentityManager::Observer::OnAccountUpdated(
      const AccountInfo& account_info);

 

Comment 1 by sdefresne@chromium.org, Jan 16 (6 days ago)

Blocking: 921061

Comment 2 by dxie@google.com, Jan 16 (6 days ago)

Blocking: 922745

Comment 3 by dxie@google.com, Jan 16 (6 days ago)

Blocking: 922747

Comment 4 by dxie@google.com, Jan 16 (6 days ago)

Blocking: 922757

Comment 5 by dxie@google.com, Jan 16 (6 days ago)

Blocking: 922758

Comment 6 by dxie@google.com, Jan 16 (6 days ago)

Blocking: 922761

Comment 7 by dxie@google.com, Jan 16 (6 days ago)

Blocking: 922762

Comment 8 by dxie@google.com, Jan 17 (6 days ago)

Blocking: 922778

Comment 9 by dxie@google.com, Jan 17 (6 days ago)

Blocking: 922779

Comment 10 by dxie@google.com, Jan 17 (6 days ago)

Blockedon: 922781

Comment 11 by dxie@google.com, Jan 17 (6 days ago)

Blocking: 922782

Comment 12 by dxie@google.com, Jan 17 (6 days ago)

Blocking: 922785

Comment 13 by dxie@google.com, Jan 17 (6 days ago)

Blocking: 922786

Comment 14 by dxie@google.com, Jan 17 (6 days ago)

Blocking: 922787

Comment 15 by dxie@google.com, Jan 17 (6 days ago)

Blockedon: 922788

Comment 16 by dxie@google.com, Jan 17 (6 days ago)

Blocking: 922792

Comment 17 by dxie@google.com, Jan 17 (6 days ago)

Blocking: 922793

Comment 18 by je_julie.kim@chromium.org, Jan 17 (5 days ago)

Owner: je_julie.kim@chromium.org
Status: Started (was: Available)
Project Member

Comment 19 by bugdroid1@chromium.org, Jan 18 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1d45207353420b1fbcad9f0dd426d65ad5e9255

commit b1d45207353420b1fbcad9f0dd426d65ad5e9255
Author: Julie Jeongeun Kim <jkim@igalia.com>
Date: Fri Jan 18 15:00:57 2019

[s13n] Add IdentityManager::Observer::OnAccountUpdated

This CL adds IdentityManager::Observer::OnAccountUpdated to
replace AccountTrackerService::Observer::OnAccountUpdated.

Test: IdentityManagerTest.ObserveOnAccountUpdated
Bug:  922469 
Change-Id: I2e787dca982dbb935925f6a00dd239aa3fe915a8
Reviewed-on: https://chromium-review.googlesource.com/c/1417433
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#624123}
[modify] https://crrev.com/b1d45207353420b1fbcad9f0dd426d65ad5e9255/services/identity/public/cpp/identity_manager.cc
[modify] https://crrev.com/b1d45207353420b1fbcad9f0dd426d65ad5e9255/services/identity/public/cpp/identity_manager.h
[modify] https://crrev.com/b1d45207353420b1fbcad9f0dd426d65ad5e9255/services/identity/public/cpp/identity_manager_unittest.cc

Comment 20 by je_julie.kim@chromium.org, Yesterday (30 hours ago)

Status: Fixed (was: Started)

Sign in to add a comment