Visible jump when opening a new tab from the tab grid |
|||
Issue descriptionTested on iPhone Xs, iOS 12. What steps will reproduce the problem? (1) Open the TabGrid (2) Tap the "+" to open a new tab What is the expected result? The animation should be smooth. What happens instead? There is a visible jump in the opening animation. It is caused by https://chromium-review.googlesource.com/c/chromium/src/+/1409546
,
Jan 18
(4 days ago)
This issue looks similar to issue 923109
,
Jan 18
(4 days ago)
Will be fixed after 2 hours.
,
Jan 18
(4 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/658d00a40859e1eb1c101d8c10fefd419ba76edf commit 658d00a40859e1eb1c101d8c10fefd419ba76edf Author: Yi Su <mrsuyi@chromium.org> Date: Fri Jan 18 14:22:58 2019 Fix tab grid transition bug of grid_cell top bar. This CLs fixes the bug caused by https://crrev/c/1409546. The tab grid transition animation is not working well because GridCell.topBarHeight constraint is not set. Bug: 922468 Change-Id: I13a9e27ac239ce2eb04240a68d2f6ff3f8996b5f Reviewed-on: https://chromium-review.googlesource.com/c/1412463 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#624106} [modify] https://crrev.com/658d00a40859e1eb1c101d8c10fefd419ba76edf/ios/chrome/browser/ui/tab_grid/grid/grid_cell.mm
,
Jan 18
(4 days ago)
,
Today
(20 hours ago)
Verified in Build: 73.0.3680.0 Canary Device Details:iPhone 8plus(iOS 12.1.3 beta #4), iPhone 8(iOS 11.4.1) Followed the steps mentioned in comment#0. The animation is now smooth, looks good. Link to video: https://drive.google.com/file/d/1NaidPXdeh55FB9PVtW0qPUgtQGBXg6Lj/view?usp=sharing |
|||
►
Sign in to add a comment |
|||
Comment 1 by mrsuyi@chromium.org
, Jan 16 (6 days ago)