New issue
Advanced search Search tips

Issue 922467 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 21
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[LayoutNG] LayoutInlineTest.RegionHitTest fails

Project Member Reported by mstensho@chromium.org, Jan 16 (6 days ago)

Issue description

Fails because LayoutInline::HitTestCulledInline() isn't provided with a parent_fragment.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 20 (2 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6906720e2b939a6c8eda7f4e102814cc72b73f5

commit a6906720e2b939a6c8eda7f4e102814cc72b73f5
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Sun Jan 20 22:53:45 2019

[LayoutNG] Fix LayoutInlineTest.RegionHitTest

The unit test crashes in LayoutNG because LayoutInline::HitTestCulledInline()
requirs a non-null NGPaintFragment parameter. This patch passes the
correct fragments to the function so that the test case doesn't crash.

Note: There are some other issues related to list-based hit tests and
culled inlines revealed by this patch. They are left for future
investigation.

Bug:  922467 
Change-Id: I86c4190330c976b5acd46e19fc0dac61c90d5eba
Reviewed-on: https://chromium-review.googlesource.com/c/1423664
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624495}
[modify] https://crrev.com/a6906720e2b939a6c8eda7f4e102814cc72b73f5/third_party/blink/renderer/core/layout/layout_inline_test.cc

Comment 2 by xiaoche...@chromium.org, Jan 21 (2 days ago)

Status: Fixed (was: Assigned)

Sign in to add a comment