swarming_bot: when the bot sends a SIGTERM to a task, discard the named cache |
|
Issue descriptionA SIGTERM is sent under these conditions: - execution hard timeout - I/O timeout - client request to kill a task Actual: If run_isolated is able to terminate properly, the named cache is kept. Expected: Whenever a SIGTERM is sent to the task, discard the named cache. Rationale: In practice, when sending a SIGTERM, we can't assume the task handles this correctly, so we're better to discard the task.
,
Jan 16
(6 days ago)
Is it possible to create a distinction between regular named caches and "disposable" named caches s.t. we could dispose of the latter but not the former in the event of a SIGTERM? (e.g., we might want to dispose of the builder cache automatically, but we probably don't want to entirely dispose of the git cache, so the former would be disposable while the latter would not be)
,
Jan 16
(6 days ago)
More knobs means the next noogler will be surprised and in general recipes will start to drift to become misconfigured*, so we must trade off carefully. * Especially that this kind of misconfiguration would only take effect under exceptional circumstances. |
|
►
Sign in to add a comment |
|
Comment 1 by vadimsh@chromium.org
, Jan 16 (6 days ago)