New issue
Advanced search Search tips

Issue 922443 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 675997



Sign in to add a comment

angle_perftests skipping all tests on Nexus 5x test config

Project Member Reported by jmad...@chromium.org, Jan 16 (6 days ago)

Issue description

This seems to be happening on the GPU.FYI and ANGLE waterfalls as well as the perf waterfall:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20FYI%20Release%20%28Nexus%205X%29/13571

https://chromium-swarm.appspot.com/task?id=426f6b27c0fe3310&refresh=10&show_raw=1

Skipping tests using configuration ES2_OPENGL because it is not available.
(etc)

Not sure when this started happening. Yuly is this something you could help looking into? We also have issue angleproject:2286 for detecting suddenly not working configs.
 

Comment 1 by ynovikov@chromium.org, Jan 16 (6 days ago)

Status: Started (was: Assigned)
This was broken by https://chromium-review.googlesource.com/c/1392382.
src/tests/test_utils/angle_test_configs.cpp used to include "common/platform.h" via:
src/tests/test_utils/angle_test_configs.h -> EGLWindow.h -> common/angleutils.h
After that CL EGLWindow.h is no longer included, thus
OPENGL_OR_GLES returns OPENGL() instead of OPENGLES() on Android.

Thus, the test complains that ES2_OPENGL is not available, while it should be trying ES2_OPENGLES instead.

Going to include "common/platform.h" explicitly everywhere it is used.
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 17 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/5fe7c5b926428d0d4dc8fa606afc7a4ab93cc49c

commit 5fe7c5b926428d0d4dc8fa606afc7a4ab93cc49c
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Thu Jan 17 18:56:04 2019

Include common/platform.h where used

Bug:  922443 
Change-Id: I35b9e34266d4a15f8d0769c2770801b1b0511398
Reviewed-on: https://chromium-review.googlesource.com/c/1418091
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

[modify] https://crrev.com/5fe7c5b926428d0d4dc8fa606afc7a4ab93cc49c/src/libANGLE/renderer/vulkan/RendererVk.cpp
[modify] https://crrev.com/5fe7c5b926428d0d4dc8fa606afc7a4ab93cc49c/src/common/utilities.h
[modify] https://crrev.com/5fe7c5b926428d0d4dc8fa606afc7a4ab93cc49c/src/tests/test_utils/ANGLETest.cpp
[modify] https://crrev.com/5fe7c5b926428d0d4dc8fa606afc7a4ab93cc49c/src/tests/perf_tests/ANGLEPerfTest.cpp
[modify] https://crrev.com/5fe7c5b926428d0d4dc8fa606afc7a4ab93cc49c/src/tests/egl_tests/EGLSurfaceTest.cpp
[modify] https://crrev.com/5fe7c5b926428d0d4dc8fa606afc7a4ab93cc49c/src/tests/test_utils/angle_test_configs.cpp
[modify] https://crrev.com/5fe7c5b926428d0d4dc8fa606afc7a4ab93cc49c/src/libANGLE/renderer/gl/renderergl_utils.cpp
[modify] https://crrev.com/5fe7c5b926428d0d4dc8fa606afc7a4ab93cc49c/src/tests/perf_tests/EGLMakeCurrentPerf.cpp
[modify] https://crrev.com/5fe7c5b926428d0d4dc8fa606afc7a4ab93cc49c/util/util_gl.h
[modify] https://crrev.com/5fe7c5b926428d0d4dc8fa606afc7a4ab93cc49c/src/common/debug.h
[modify] https://crrev.com/5fe7c5b926428d0d4dc8fa606afc7a4ab93cc49c/src/common/aligned_memory.cpp
[modify] https://crrev.com/5fe7c5b926428d0d4dc8fa606afc7a4ab93cc49c/src/tests/test_utils/angle_test_instantiate.cpp
[modify] https://crrev.com/5fe7c5b926428d0d4dc8fa606afc7a4ab93cc49c/util/posix/Posix_system_utils.cpp
[modify] https://crrev.com/5fe7c5b926428d0d4dc8fa606afc7a4ab93cc49c/src/tests/perf_tests/VulkanCommandBufferPerf.cpp

Comment 3 by ynovikov@chromium.org, Jan 17 (5 days ago)

Status: Verified (was: Started)
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20FYI%20Release%20%28Nexus%205X%29/13624

I   60.366s Main  Will run 41 tests on 1 devices: 01f0b4d3e9933b99
D   60.366s Main    BindingsBenchmark.Run/gles_100_objects_allocated_at_initialization
D   60.366s Main    BindingsBenchmark.Run/gles_100_objects_allocated_every_iteration
D   60.366s Main    BufferSubDataBenchmark.Run/gles_float4_every1
D   60.366s Main    DispatchComputePerfBenchmark.Run/gles
D   60.366s Main    DispatchComputePerfBenchmark.Run/gles_null
D   60.366s Main    DrawCallPerfBenchmark.Run/default_validation_only
D   60.366s Main    DrawCallPerfBenchmark.Run/gles
D   60.366s Main    DrawCallPerfBenchmark.Run/gles_null
D   60.366s Main    DrawCallPerfBenchmark.Run/gles_null_tex_change
D   60.366s Main    DrawCallPerfBenchmark.Run/gles_null_vbo_change
D   60.366s Main    DrawCallPerfBenchmark.Run/gles_render_to_texture_null
D   60.366s Main    DrawCallPerfBenchmark.Run/gles_tex_change
D   60.366s Main    DrawCallPerfBenchmark.Run/gles_vbo_change
D   60.366s Main    DrawCallPerfBenchmark.Run/wgl
D   60.366s Main    DrawCallPerfBenchmark.Run/wgl_tex_change
D   60.366s Main    DrawCallPerfBenchmark.Run/wgl_vbo_change
D   60.366s Main    DrawElementsPerfBenchmark.Run/gles
D   60.366s Main    DrawElementsPerfBenchmark.Run/gles_index_buffer_changed
D   60.366s Main    DrawElementsPerfBenchmark.Run/gles_index_buffer_changed_ushort
D   60.366s Main    DrawElementsPerfBenchmark.Run/gles_null_ushort
D   60.366s Main    DrawElementsPerfBenchmark.Run/gles_ushort
D   60.366s Main    DrawElementsPerfBenchmark.Run/wgl_ushort
D   60.366s Main    InstancingPerfBenchmark.Run/gles
D   60.366s Main    InterleavedAttributeDataBenchmark.Run/gles
D   60.366s Main    LinkProgramBenchmark.Run/gles_compile_and_link_multi_thread
D   60.366s Main    LinkProgramBenchmark.Run/gles_compile_and_link_single_thread
D   60.366s Main    LinkProgramBenchmark.Run/gles_compile_only_multi_thread
D   60.366s Main    LinkProgramBenchmark.Run/gles_compile_only_single_thread
D   60.366s Main    MultiviewCPUBoundBenchmark.Run/gles_instanced_multiview_vertex_shader_2_views
D   60.366s Main    MultiviewCPUBoundBenchmark.Run/gles_no_acc_2_views
D   60.366s Main    MultiviewGPUBoundBenchmark.Run/gles_instanced_multiview_vertex_shader_2_views
D   60.366s Main    MultiviewGPUBoundBenchmark.Run/gles_no_acc_2_views
D   60.366s Main    PointSpritesBenchmark.Run/gles_10_3px_3vars
D   60.366s Main    TexSubImageBenchmark.Run/gles
D   60.367s Main    TextureSamplingBenchmark.Run/gles_2samplers
D   60.367s Main    TexturesBenchmark.Run/gles_8_textures_5_rebind_3_state_8_mips
D   60.367s Main    TexturesBenchmark.Run/gles_8_textures_5_rebind_3_state_8_mips_webgl
D   60.367s Main    UniformsBenchmark.Run/gles_400_vec4
D   60.367s Main    UniformsBenchmark.Run/gles_400_vec4_repeating
D   60.367s Main    UniformsBenchmark.Run/gles_matrix
D   60.367s Main    UniformsBenchmark.Run/gles_null_400_vec4

...

C   75.584s Main  [==========] 41 tests ran.
C   75.584s Main  [  PASSED  ] 41 tests.

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 18 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74ee536827fa1558a29601be3959c1f109da5fd0

commit 74ee536827fa1558a29601be3959c1f109da5fd0
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Fri Jan 18 00:39:32 2019

Roll src/third_party/angle b3bdd2acc4f0..5fe7c5b92642 (3 commits)

https://chromium.googlesource.com/angle/angle.git/+log/b3bdd2acc4f0..5fe7c5b92642


git log b3bdd2acc4f0..5fe7c5b92642 --date=short --no-merges --format='%ad %ae %s'
2019-01-17 ynovikov@chromium.org Include common/platform.h where used
2019-01-17 geofflang@chromium.org Reland "Don't call Texture::onDestroy twice for the zero textures."
2019-01-17 geofflang@chromium.org GL: Temporarily disable parallel shader compile.


Created with:
  gclient setdep -r src/third_party/angle@5fe7c5b92642

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:922443 , chromium:922296 ,chromium:922936,chromium:849576
TBR=cwallez@chromium.org

Change-Id: I970bdb5c71c8dd228901354565301076ca794675
Reviewed-on: https://chromium-review.googlesource.com/c/1418126
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#623929}
[modify] https://crrev.com/74ee536827fa1558a29601be3959c1f109da5fd0/DEPS

Sign in to add a comment