New issue
Advanced search Search tips

Issue 922431 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

::placeholder does not work with ::part

Project Member Reported by fergal@chromium.org, Jan 16 (6 days ago)

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Jan 17 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbe3bb5ff15b5ce1b6b1392fdc786087eaedb47a

commit cbe3bb5ff15b5ce1b6b1392fdc786087eaedb47a
Author: Fergal Daly <fergal@chromium.org>
Date: Thu Jan 17 22:50:43 2019

[CSS] Make ::part(foo)::placeholder work.

This copies the ::slotted::placeholder approach and adds a
StyleResolver::MatchPseudoPartRulesForUAHost.

This also adds a reftest due to the fact that getComputedStyle does
not work with "::placeholder" -  https://crbug.com/922431 . It leaves the
old test in place because other browsers may support it and the hopefully
blink will in the future.

Bug:  922431 
Change-Id: Iec4d9b279cf1f82dbdcbcc69dcac873678943882
Reviewed-on: https://chromium-review.googlesource.com/c/1415066
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623885}
[modify] https://crrev.com/cbe3bb5ff15b5ce1b6b1392fdc786087eaedb47a/third_party/blink/renderer/core/css/css_selector.cc
[modify] https://crrev.com/cbe3bb5ff15b5ce1b6b1392fdc786087eaedb47a/third_party/blink/renderer/core/css/css_selector.h
[modify] https://crrev.com/cbe3bb5ff15b5ce1b6b1392fdc786087eaedb47a/third_party/blink/renderer/core/css/resolver/style_resolver.cc
[modify] https://crrev.com/cbe3bb5ff15b5ce1b6b1392fdc786087eaedb47a/third_party/blink/renderer/core/css/resolver/style_resolver.h
[modify] https://crrev.com/cbe3bb5ff15b5ce1b6b1392fdc786087eaedb47a/third_party/blink/renderer/core/css/rule_set.cc
[add] https://crrev.com/cbe3bb5ff15b5ce1b6b1392fdc786087eaedb47a/third_party/blink/web_tests/external/wpt/css/css-shadow-parts/interaction-with-placeholder-ref.html
[add] https://crrev.com/cbe3bb5ff15b5ce1b6b1392fdc786087eaedb47a/third_party/blink/web_tests/external/wpt/css/css-shadow-parts/interaction-with-placeholder.html

Comment 2 by fergal@chromium.org, Jan 18 (5 days ago)

Status: Fixed (was: Assigned)

Sign in to add a comment