New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 922416 link

Starred by 1 user

Issue metadata

Status: Unconfirmed
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

[Findit] Flake Analyzer - Wrong culprit r622514

Project Member Reported by atotic@chromium.org, Jan 16 (6 days ago)

Issue description

Link to Culprit: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZDI4OWNjM2QxODEzM2IyMTQzNDM4MTM1NzhiZDcxYmM0ODgzNzMwNQw

My suspect CL only changed code that runs with LayoutNG runtime flag.
This code does not run for the flaky test:
WorkletAnimationTest.CurrentTimeFromDocumentTimelineIsOffsetByStartTime
So there is no way it is a culprit.

The reason why FindIt might have flagged this CL is that I committed it without running the test suite. I had to use:

Notry: true

The reason is that this CL made linux_layout_tests_layout_ng fail. In particular,
All/FrameThrottlingTest.ThrottleSubtreeAtomically/2 from webkit_unit_tests_ng was failing.

Since we have no way to mark these types of tests as failing in LayoutNG, I had to force land it.
 

Sign in to add a comment