New issue
Advanced search Search tips

Issue 922409 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 18
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 894651



Sign in to add a comment

[LayoutNG] SelectionModifierTest failures

Project Member Reported by mstensho@chromium.org, Jan 16 (6 days ago)

Issue description

The following SelectionModifierTest tests are failing with LayoutNG:

SelectionModifierTest.leftPositionOf
SelectionModifierTest.rightPositionOf

 

Comment 1 by xiaoche...@chromium.org, Jan 16 (6 days ago)

Blockedon: 894651
Labels: -Pri-2 Pri-3
These two are only used in contenteditable for visual left/right caret movements.

Hence P3.

Comment 2 by mstensho@chromium.org, Jan 16 (6 days ago)

Can we just disable the tests for LayoutNG in the meantime then?
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 18 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00b0d29817ee895c4cb45c32fc80f719a203593e

commit 00b0d29817ee895c4cb45c32fc80f719a203593e
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Fri Jan 18 20:55:27 2019

[LayoutNG] Suppress SelectionModifierTest failures

LeftPositionsOf() and RightPositionsOf() are for visual caret movement
in editable text only. Suppress them for now since we are still falling
back to legacy for contenteditable.

Bug:  922409 
Change-Id: Ic14a399aad93079266e031b1f58cd00d1a0c8678
Reviewed-on: https://chromium-review.googlesource.com/c/1422843
Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624276}
[modify] https://crrev.com/00b0d29817ee895c4cb45c32fc80f719a203593e/third_party/blink/renderer/core/editing/selection_modifier_test.cc

Comment 4 by xiaoche...@chromium.org, Jan 18 (4 days ago)

Status: Fixed (was: Assigned)

Sign in to add a comment