New issue
Advanced search Search tips

Issue 922406 link

Starred by 1 user
Status: Assigned
Owner:
droger@chromium.org
Cc:
blundell@chromium.org
msarda@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove OAuth2TokenService::Observer::OnStartBatchChanges

Project Member Reported by droger@chromium.org, Jan 16 (6 days ago) 
This notification is plumbed through identity manager (OnStartBatchOfRefreshTokenStateChanges) and to objective-C (IdentityManagerObserverBridge and OAuth2TokenServiceObserverBridge), but at the end there are no users of this. We could probably remove the observer method and the corresponding plumbing.

Comment 1 by blundell@google.com, Jan 16 (6 days ago) 

Yes! I had looked at this once and come to the same observation. The only complexity that I saw is that this method is used in tests for the tests to be able to count nesting depth of batch changes. That shouldn't be a blocker but prevented me from just immediately stripping it out in the ~5 minutes I took to examine it at the time.
►

Sign in to add a comment