New issue
Advanced search Search tips

Issue 922404 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression


Show other hotlists

Hotlists containing this issue:
Launcher-Broken


Sign in to add a comment

Regression: App launcher closes on rotating the display

Project Member Reported by rkalavakuntla@chromium.org, Jan 16 (6 days ago)

Issue description

Chrome Version:73.0.3699.0/11591.0.0 dev channel Daisy,Kip,Reks  
OS:Chrome OS

What steps will reproduce the problem?
(1)Sign into user >> Keep open app launcher in maximize mode
(2)Now rotate the display and observe app launcher closes(please refer video) 

Actual: App launcher closes on rotating the display
Expected:App launcher should not close while rotating the display

This is Regression Issue as same works fine in 71.0.3578.127/11151.113.0 stable

Note: Issue is seen in 72.0.3626.0
 
Actual.mp4
5.0 MB View Download
Expected.mp4
4.0 MB View Download

Comment 1 by newcomer@chromium.org, Jan 16 (6 days ago)

Labels: -Pri-1 Pri-2
Status: Available (was: Untriaged)
Thank you for reporting!

Comment 2 by weidongg@chromium.org, Jan 18 (4 days ago)

Owner: weidongg@chromium.org
Status: Started (was: Available)

Comment 3 by weidongg@chromium.org, Jan 18 (4 days ago)

Cc: afakhry@chromium.org
It seems to be caused by the CL: https://chromium-review.googlesource.com/c/chromium/src/+/1325389

+afakhry@ for review on the fix: https://chromium-review.googlesource.com/c/chromium/src/+/1423129
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 19 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31dfeef37bfb494c9ca67d9043f3d04f0800615e

commit 31dfeef37bfb494c9ca67d9043f3d04f0800615e
Author: Weidong Guo <weidongg@chromium.org>
Date: Sat Jan 19 00:18:54 2019

Make app list stay open after display update

Changes:
Avoid dismissing app list on display configuration changes.

Bug:  922404 
Test: AppListPresenterDelegateTest.UpdateDisplayNotCloseAppList
Change-Id: Id54fd33626e7f0bb88e67bd7d73a278f3d0a7485
Reviewed-on: https://chromium-review.googlesource.com/c/1423129
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624374}
[modify] https://crrev.com/31dfeef37bfb494c9ca67d9043f3d04f0800615e/ash/app_list/app_list_controller_impl.cc
[modify] https://crrev.com/31dfeef37bfb494c9ca67d9043f3d04f0800615e/ash/app_list/app_list_presenter_delegate_unittest.cc

Comment 5 by weidongg@chromium.org, Jan 19 (4 days ago)

Status: Fixed (was: Started)

Sign in to add a comment