New issue
Advanced search Search tips

Issue 922398 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

CHECK failure: pending_start_update_callback_.is_null() && pending_swap_cache_callback_.is_null

Project Member Reported by ClusterFuzz, Jan 16 (6 days ago)

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5170557951410176

Fuzzer: libFuzzer_appcache_fuzzer
Fuzz target binary: appcache_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  pending_start_update_callback_.is_null() && pending_swap_cache_callback_.is_null
  content::AppCacheHost::SwapCacheWithCallback
  content::AppCacheBackendImpl::SwapCacheWithCallback
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=605707:605715

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5170557951410176

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for instructions to reproduce this bug locally.
 
Project Member

Comment 1 by ClusterFuzz, Jan 16 (6 days ago)

Components: Blink>Storage>AppCache
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Jan 16 (6 days ago)

Cc: mmoroz@chromium.org
Labels: ClusterFuzz-Auto-CC
Automatically adding ccs based on OWNERS file / target commit history.

If this is incorrect, please add ClusterFuzz-Wrong label.
Project Member

Comment 3 by ClusterFuzz, Jan 16 (6 days ago)

Labels: Test-Predator-Auto-Owner
Owner: mmoroz@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/f83007304ba201e3a0ee9eaf198d369aa48f6090 (Add appcache_fuzzer).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.

Comment 4 by mmoroz@chromium.org, Jan 16 (6 days ago)

Cc: -mmoroz@chromium.org jsb...@chromium.org nedwill@google.com
Owner: pwnall@chromium.org

Comment 5 by mek@chromium.org, Jan 16 (6 days ago)

Cc: pwnall@chromium.org
Owner: mek@chromium.org

Comment 6 by pwnall@chromium.org, Jan 16 (6 days ago)

mek@: Thank you very much for taking this on!
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 17 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2761bb080c9f9c2a84614616e851ed2dc1c669d9

commit 2761bb080c9f9c2a84614616e851ed2dc1c669d9
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Thu Jan 17 00:44:04 2019

[AppCache] ReportBadMessage rather than DCHECK for preconditions on mojo API.

Nothing stops a renderer from calling these methods while another call
is still processing, so ReportBadMessage rather than DCHECK when that
happens.

Bug:  922398 
Change-Id: I2ab0abf245828eaa81ce8fbfbc7396db03029d86
Reviewed-on: https://chromium-review.googlesource.com/c/1416092
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623462}
[modify] https://crrev.com/2761bb080c9f9c2a84614616e851ed2dc1c669d9/content/browser/appcache/appcache_backend_impl.cc
[modify] https://crrev.com/2761bb080c9f9c2a84614616e851ed2dc1c669d9/content/browser/appcache/appcache_backend_impl.h
[modify] https://crrev.com/2761bb080c9f9c2a84614616e851ed2dc1c669d9/content/browser/appcache/appcache_dispatcher_host.cc
[modify] https://crrev.com/2761bb080c9f9c2a84614616e851ed2dc1c669d9/content/browser/appcache/appcache_host.cc
[modify] https://crrev.com/2761bb080c9f9c2a84614616e851ed2dc1c669d9/content/browser/appcache/appcache_host.h

Comment 8 by mek@chromium.org, Jan 17 (6 days ago)

Status: Fixed (was: Assigned)
Project Member

Comment 9 by ClusterFuzz, Jan 17 (5 days ago)

ClusterFuzz has detected this issue as fixed in range 623461:623463.

Detailed report: https://clusterfuzz.com/testcase?key=5170557951410176

Fuzzer: libFuzzer_appcache_fuzzer
Fuzz target binary: appcache_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  pending_start_update_callback_.is_null() && pending_swap_cache_callback_.is_null
  content::AppCacheHost::SwapCacheWithCallback
  content::AppCacheBackendImpl::SwapCacheWithCallback
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=605707:605715
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=623461:623463

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5170557951410176

See https://github.com/google/clusterfuzz-tools for instructions to reproduce this bug locally.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, Jan 17 (5 days ago)

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5170557951410176 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment