New issue
Advanced search Search tips

Issue 922393 link

Starred by 1 user
Status: Fixed
Owner:
rbpotter@chromium.org
Closed: Jan 18
Cc:
nyerramilli@chromium.org
pbomm...@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 920056



Sign in to add a comment

Regression: Focus is lost from print preview overlay after dismissing 'Select a destination' overlay.

Project Member Reported by sany...@virtusa.com, Jan 16 (6 days ago) 
Chrome Version:  73.0.3673.0 (Official Build) Revision e5cdf80fb8b493b3be23fc5b7bfac5278aa83225-refs/branch-heads/3673@{#1}(32/64 bit)
 	
OS: Mac(10.13.1, 10.13.6, 10.14.3), Win(7,8,8.1,10)
	       
What steps will reproduce the problem?
1. Launch chrome and give print command on NTP 
2. Open 'Select a destination' overlay from Destinations drop down.
3. Press escape key to dismiss the 'Select a destination' overlay and observe the focus.

Actual Result: Focus is lost from print preview overlay after dismissing 'Select a destination' overlay.
Expected Result: Focus should not get lost from print preview overlay after dismissing 'Select a destination' overlay.

This is a regression issue broken in M-73 and will soon update other info:
Good Build : 73.0.3672.0(Revision:622689)
Bad Build : 73.0.3673.0(Revision:622911)

Kindly refer the screen cast for reference

Thank You!
Actual Result.mov
1.4 MB View Download
Expected Result.mov
1.3 MB View Download

Comment 1 by sany...@virtusa.com, Jan 16 (6 days ago)

Labels: hasbisect-per-revision OS-Linux
Owner: rbpotter@chromium.org
Status: Assigned (was: Unconfirmed)
Update:

You are probably looking for a change made after 622876 (known good), but no later than 622877 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/366e4af330b7bc6b1ff344f3117f06d66ebe6d5b..74895a5ca096beb4ce24517711d90ae4ec30f2fa

Suspect: https://chromium.googlesource.com/chromium/src/+/74895a5ca096beb4ce24517711d90ae4ec30f2fa

rbpotter: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thank You..!

Comment 2 by nyerramilli@google.com, Jan 16 (6 days ago)

Cc: pbomm...@chromium.org
Labels: ReleaseBlock-Stable
marking as RBS, please change if required

Comment 3 by rbpotter@chromium.org, Jan 16 (6 days ago)

Blocking: 920056
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 17 (5 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2568ca9386adf1bcc628fd0ae4a9ec7c88269895

commit 2568ca9386adf1bcc628fd0ae4a9ec7c88269895
Author: rbpotter <rbpotter@chromium.org>
Date: Thu Jan 17 22:46:17 2019

Print Preview Destinations Dropdown: Focus fixes

- Fix an issue with the dropdown getting disabled and therefore losing
focus.
- Keep dropdown items in order until new items are added to the list.
The previous behavior of rearranging them as the recent destinations
updated was not good for keyboard use.
- Add SelectBehavior to this dropdown to debounce rapid changes
- Some polish fixes, to align dropdown positioning and width with other
dropdowns in Print Preview.

Bug: 920056,  922382 ,  922393 
Change-Id: I7c71be678ce0320a3050c1f4169837a9c139a571
Reviewed-on: https://chromium-review.googlesource.com/c/1417112
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623882}
[modify] https://crrev.com/2568ca9386adf1bcc628fd0ae4a9ec7c88269895/chrome/browser/resources/print_preview/new/BUILD.gn
[modify] https://crrev.com/2568ca9386adf1bcc628fd0ae4a9ec7c88269895/chrome/browser/resources/print_preview/new/destination_select.html
[modify] https://crrev.com/2568ca9386adf1bcc628fd0ae4a9ec7c88269895/chrome/browser/resources/print_preview/new/destination_select.js
[modify] https://crrev.com/2568ca9386adf1bcc628fd0ae4a9ec7c88269895/chrome/browser/resources/print_preview/new/destination_settings.html
[modify] https://crrev.com/2568ca9386adf1bcc628fd0ae4a9ec7c88269895/chrome/browser/resources/print_preview/new/destination_settings.js
[modify] https://crrev.com/2568ca9386adf1bcc628fd0ae4a9ec7c88269895/chrome/test/data/webui/print_preview/destination_select_test.js
[modify] https://crrev.com/2568ca9386adf1bcc628fd0ae4a9ec7c88269895/chrome/test/data/webui/print_preview/destination_settings_test.js

Comment 5 by rbpotter@chromium.org, Jan 18 (4 days ago)

Status: Fixed (was: Assigned)
Seems to be fixed here on Windows 10 on current Canary (73.0.3676.0).

Comment 6 by sany...@virtusa.com, Jan 21 (2 days ago) 

Update:

Rechecked the above issue on Mac(10.13.1, 10.13.6, 10.14.3), Win(7,8,8.1,10) and Linux (14.04 LTS) OS using latest Canary 73.0.3678.0 and the issue is fixed.Kindly refer the attached screen cast.

Thank you
Canary Behaviour.mov
2.3 MB View Download
►

Sign in to add a comment