See roll: https://crrev.com/c/1413874 Seems to fail because of the googletest roll.
Looks like we need to port the extra changes made in https://chromium.googlesource.com/chromium/src/+/bad68fb909113708fa3d8e911d79a8c12ee64805
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/84ff79a3b9326d2d4942e8ff1ff64588a1c700b4 commit 84ff79a3b9326d2d4942e8ff1ff64588a1c700b4 Author: Michael Achenbach <machenbach@chromium.org> Date: Wed Jan 16 09:12:26 2019 Update V8 DEPS. Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/02ccb16..7a1aacd Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/9d61cbb..40194ab Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/96320b5..78448d9 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/8432ec2..e229a0e Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/879ac09..933e5df This also ports https://crrev.com/c/1410527 for the gtest roll. TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Bug: chromium:922379 Change-Id: I65347892b6d2df3b6b30d8688367b39f4e76e25a Reviewed-on: https://chromium-review.googlesource.com/c/1413874 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#58841} [modify] https://crrev.com/84ff79a3b9326d2d4942e8ff1ff64588a1c700b4/DEPS [modify] https://crrev.com/84ff79a3b9326d2d4942e8ff1ff64588a1c700b4/third_party/googletest/BUILD.gn [modify] https://crrev.com/84ff79a3b9326d2d4942e8ff1ff64588a1c700b4/third_party/googletest/README.chromium
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/71cb4777e74fa747738c3496b542998f4bd5f206 commit 71cb4777e74fa747738c3496b542998f4bd5f206 Author: Sergiy Belozorov <sergiyb@chromium.org> Date: Tue Jan 22 14:49:04 2019 Update V8 DEPS. Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/402bc6d..4b7e3ce Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/879ac09..9518a57 This also ports: https://crrev.com/c/1410527 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Bug: chromium:922379 Change-Id: I3982ace35bb762e7f5c85ba9468739aedd3bcd78 Reviewed-on: https://chromium-review.googlesource.com/c/1424659 Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#58994} [modify] https://crrev.com/71cb4777e74fa747738c3496b542998f4bd5f206/DEPS [modify] https://crrev.com/71cb4777e74fa747738c3496b542998f4bd5f206/third_party/googletest/BUILD.gn [modify] https://crrev.com/71cb4777e74fa747738c3496b542998f4bd5f206/third_party/googletest/README.chromium
Comment 1 by machenbach@google.com
, Jan 16 (6 days ago)