[Resource-Timing] `name` provides the post-redirection URL for http=>https redirections |
||
Issue descriptionChrome Version: M73 OS: N/A What steps will reproduce the problem? (1) Run the test on https://chromium-review.googlesource.com/c/chromium/src/+/1411929 (2) Cry (3) Cry some more What is the expected result? Test should pass What happens instead? It fails Please use labels and text to provide additional information. If this is a regression (i.e., worked before), please consider using the bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help us identify the root cause and more rapidly triage the issue. For graphics-related bugs, please copy/paste the contents of the about://gpu page at the end of this report.
,
Jan 16
(6 days ago)
I think so. If this issue is not urgent, out-of-blink CORS will fix it.
,
Jan 16
(6 days ago)
When is that supposed to land?
,
Jan 16
(6 days ago)
We're running finch on Canary. See issue 736308.
,
Jan 16
(6 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ba90c2f9ee6e23c0ff0b22bc4ef0ae9477c57ad commit 5ba90c2f9ee6e23c0ff0b22bc4ef0ae9477c57ad Author: Yoav Weiss <yoavweiss@chromium.org> Date: Wed Jan 16 18:06:39 2019 [Resource-Timing] `name` is wrong for http to https redirection According to the spec, the `name` attribute MUST provide the pre-redirection URL. In the case of http=>https redirections, that's not the case and the post-redirection URL is provided. This CL fixes that. BUG= 922365 Change-Id: Ic9acf354ef66d654ab41259aa0af297a56e775ce Reviewed-on: https://chromium-review.googlesource.com/c/1411929 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#623293} [modify] https://crrev.com/5ba90c2f9ee6e23c0ff0b22bc4ef0ae9477c57ad/third_party/blink/renderer/core/loader/threadable_loader.cc [modify] https://crrev.com/5ba90c2f9ee6e23c0ff0b22bc4ef0ae9477c57ad/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc [modify] https://crrev.com/5ba90c2f9ee6e23c0ff0b22bc4ef0ae9477c57ad/third_party/blink/renderer/platform/loader/fetch/resource_request.cc [modify] https://crrev.com/5ba90c2f9ee6e23c0ff0b22bc4ef0ae9477c57ad/third_party/blink/renderer/platform/loader/fetch/resource_request.h [rename] https://crrev.com/5ba90c2f9ee6e23c0ff0b22bc4ef0ae9477c57ad/third_party/blink/web_tests/external/wpt/resource-timing/redirects.sub.html [add] https://crrev.com/5ba90c2f9ee6e23c0ff0b22bc4ef0ae9477c57ad/third_party/blink/web_tests/external/wpt/resource-timing/resources/blank_page_green.htm.headers
,
Jan 17
(5 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9dc341fd7d70ef121bec311a1b7eaa1dce5828c0 commit 9dc341fd7d70ef121bec311a1b7eaa1dce5828c0 Author: Yoav Weiss <yoavweiss@chromium.org> Date: Thu Jan 17 11:04:47 2019 Renamed ResourceRequest::OriginalUrl to InitialUrlForResourceTiming Following feedback on [1], this is renaming OriginalUrl and commenting it, to make it clear that it's a temporary stop-gap that should not be used beyond the scope of ResourceTiming and should be removed once Out-of-Blink CORS is shipped. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1411929 Bug: 922365 Change-Id: I0bac3a13a4e765270cb911eaa1ab728bdd369d90 Reviewed-on: https://chromium-review.googlesource.com/c/1415261 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#623641} [modify] https://crrev.com/9dc341fd7d70ef121bec311a1b7eaa1dce5828c0/third_party/blink/renderer/core/loader/threadable_loader.cc [modify] https://crrev.com/9dc341fd7d70ef121bec311a1b7eaa1dce5828c0/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc [modify] https://crrev.com/9dc341fd7d70ef121bec311a1b7eaa1dce5828c0/third_party/blink/renderer/platform/loader/fetch/resource_request.cc [modify] https://crrev.com/9dc341fd7d70ef121bec311a1b7eaa1dce5828c0/third_party/blink/renderer/platform/loader/fetch/resource_request.h
,
Jan 17
(5 days ago)
|
||
►
Sign in to add a comment |
||
Comment 1 by yoavweiss@chromium.org
, Jan 16 (6 days ago)