New issue
Advanced search Search tips

Issue 922349 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 2
Type: Task

Blocking:
issue 894819


Participants' hotlists:
ResourceLoadViaDataPipe


Sign in to add a comment

ResourceLoadViaDataPipe: Read data pipe passed on WebURLLoaderImpl

Project Member Reported by shimazu@chromium.org, Jan 16

Issue description

When ResourceLoadViaDataPipe is on, So far WebURLLoaderImpl gets a data pipe for body but it's not routed correctly.
WebURLLoaderImpl needs to read the data pipe and plumb a chunk of body to the client for turning the flag on.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 18 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fb54d546e833de89bcc5b744fe48d188bea1e7a

commit 7fb54d546e833de89bcc5b744fe48d188bea1e7a
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Fri Jan 18 08:34:01 2019

ResourceLoadViaDataPipe: Read body at WebURLLoaderImpl

RequestPeer passes the body as a Mojo's data pipe when ResourceLoadViaDataPipe
is on. This CL is to read the body at WebURLLoaderImpl. From this CL, page loads
successfully run with the feature flag.

Bug:  922349 
Change-Id: Ib2b222f1e4e45f427d680efb539ea31ce71af657
Reviewed-on: https://chromium-review.googlesource.com/c/1414711
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Auto-Submit: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624037}
[modify] https://crrev.com/7fb54d546e833de89bcc5b744fe48d188bea1e7a/content/renderer/loader/web_url_loader_impl.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 18 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3c7a4f1401be0f35545c7075da44268b466c63e

commit c3c7a4f1401be0f35545c7075da44268b466c63e
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Fri Jan 18 10:47:02 2019

Add unittests for WebURLLoaderImpl when ResourceLoadViaDataPipe is on

Bug:  922349 
Change-Id: Ic2e6f66076485b279ecb4c9da654c784fbfe4c0d
Reviewed-on: https://chromium-review.googlesource.com/c/1420398
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624061}
[modify] https://crrev.com/c3c7a4f1401be0f35545c7075da44268b466c63e/content/renderer/loader/web_url_loader_impl_unittest.cc

Comment 3 by shimazu@chromium.org, Jan 21 (2 days ago)

Status: Fixed (was: Started)

Sign in to add a comment