link-header-preload-srcset.tentative.html fails on wpt.fyi dashboard |
|
Issue descriptionhttps://wpt.fyi/results/preload?label=master&q=srcset When I open http://w3c-test.org/preload/link-header-preload-srcset.tentative.html with Chrome dev, it succeeds on the first load but fails on second+ loads, because "dummy.js?pipe=trickle(d3)&link-header-preload-srcset" is served from disk cache. We should make that response non-cacheable, or just use timeout instead. Note: link-header-preload-nonce.html has the same issue.
,
Jan 16
(6 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e4e5d7297698d2a4bc5353a28b511663d28fc40 commit 8e4e5d7297698d2a4bc5353a28b511663d28fc40 Author: Kunihiko Sakamoto <ksakamoto@chromium.org> Date: Wed Jan 16 08:42:34 2019 Fix preload tests failing on wpt.fyi dashboard verifyNumberOfDownloads only counts resource timing entries with transferSize > 0, so it doesn't count if the resource came from a cache. (See https://bugzilla.mozilla.org/show_bug.cgi?id=1222633#c38 for background why we have it.) link-header-preload-nonce.html and link-header-preload-srcset.tentative.html were failing on wpt.fyi dashboard because they have used the same subresource URLs as other tests, and preloaded resources from the disk cache. This patch adds unique query parameters to these URLs so that they don't conflict with other tests. Bug: 922343 Change-Id: I7fd88530f5fdd83ed2a22d2e2893cc446debd036 Reviewed-on: https://chromium-review.googlesource.com/c/1411963 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#623157} [modify] https://crrev.com/8e4e5d7297698d2a4bc5353a28b511663d28fc40/third_party/blink/web_tests/external/wpt/preload/link-header-preload-nonce.html [modify] https://crrev.com/8e4e5d7297698d2a4bc5353a28b511663d28fc40/third_party/blink/web_tests/external/wpt/preload/link-header-preload-nonce.html.headers [modify] https://crrev.com/8e4e5d7297698d2a4bc5353a28b511663d28fc40/third_party/blink/web_tests/external/wpt/preload/link-header-preload-srcset.tentative.html [modify] https://crrev.com/8e4e5d7297698d2a4bc5353a28b511663d28fc40/third_party/blink/web_tests/external/wpt/preload/link-header-preload-srcset.tentative.html.headers
,
Jan 16
(6 days ago)
Sweet, thanks for fixing this! |
|
►
Sign in to add a comment |
|
Comment 1 by ksakamoto@chromium.org
, Jan 16 (6 days ago)