Regression: [PIP]Focus skips and does not shift to 'Back to tab' icon after pressing tab for the first instance |
||||
Issue descriptionChrome Version : 73.0.3672.0 (Official Build) Revision 85c08445cbd3b2c184402109493da9e9ad4b4dfa-refs/branch-heads/3672@{#1}(32/64 bit) OS : Windows(7,8,8.1,10), Mac(10.13.1, 10.13.6, 10.14.3) Test URL : http://googlechrome.github.io/samples/picture-in-picture What steps will reproduce the problem? 1. Launch chrome, and navigate to above test URL. 2. Click on the 'Picture-in-Picture' option from 3 dot menu of the media controls. 3. Observe blue focus ring is around the Play icon on the Picture-in-Picture window. 4. Now press tab and observe focus. Actual Result : Blue focus ring skips and does not shift to 'Back to tab' icon after pressing tab for the first time. Expected Result : Blue focus ring should shift directly to 'Back to tab' icon after pressing tab on 'Play/Pause button'. This is a regression issue broken in M-73 and below is the per revision bisect information: Good Build : 73.0.3671.0 (Revision : 622374) Bad Build : 73.0.3672.0 (Revision : 622688) You are probably looking for a change made after 622410 (known good), but no later than 622411 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/29499f8145d40af2cfa85a0449e7a6269746b3e6..a376eb709ec4f22485cb2552f4a6d46f79e8a4cc Suspect: https://chromium.googlesource.com/chromium/src/+/a376eb709ec4f22485cb2552f4a6d46f79e8a4cc @beaufort.francois: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Kindly refer attached screen cast. Thank you
,
Yesterday
(45 hours ago)
WIP CL at https://chromium-review.googlesource.com/c/chromium/src/+/1422700
,
Yesterday
(36 hours ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74ed83f004dce34ff89eaa73a805f7cf19721490 commit 74ed83f004dce34ff89eaa73a805f7cf19721490 Author: François Beaufort <beaufort.francois@gmail.com> Date: Mon Jan 21 18:06:31 2019 Do not focus Skip Ad button if invisible in Picture-in-Picture window This CL makes sure the new Skip Ad button in the Picture-in-Picture window is not focused when it is not visible. Bug: 922339 Change-Id: I8ae65fc2c5691d8abc66dec76bd254b88a3fa033 Reviewed-on: https://chromium-review.googlesource.com/c/1422700 Auto-Submit: François Beaufort <beaufort.francois@gmail.com> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#624621} [modify] https://crrev.com/74ed83f004dce34ff89eaa73a805f7cf19721490/chrome/browser/ui/views/overlay/overlay_window_views.cc
,
Today
(21 hours ago)
Fixed in Chromium 73.0.3681.0
,
Today
(19 hours ago)
Update: Rechecked the above issue on Windows(7,8,8.1,10), Mac(10.13.1, 10.13.6, 10.14.3)OS using latest Canary build #73.0.3680.0 and the issue is fixed. Kindly refer attached screen cast. Thank you |
||||
►
Sign in to add a comment |
||||
Comment 1 by fbeaufort@chromium.org
, Jan 16 (6 days ago)Owner: fbeaufort@chromium.org