Findit identified the culprit r622873 as introducing flaky test(s) summarized in https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMGE1Y2JiYmVkODAwNTllMWEwZGQzZTY4NGRiODg5ODdmOWI0MjM0YQw Please revert the culprit or disable the test(s) asap. If you are the owner, please fix! If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20culprit%20r622873&comment=Link%20to%20Culprit%3A%20https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMGE1Y2JiYmVkODAwNTllMWEwZGQzZTY4NGRiODg5ODdmOWI0MjM0YQw Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Removing the sheriff label as the CL has already been reverted.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0 commit ebbcef1f17bc37f5380bd7e87a17016defd1fdd0 Author: Nate Chapin <japhet@chromium.org> Date: Fri Jan 18 08:21:24 2019 Run Javascript urls through the document, attempt #2 Put them on a timer and have them block the load event. This guarantees that JS urls will always run asynchronously, improving spec compliance. It also will allow us to depend far less on NavigationScheduler for our async navigation needs, hopefully allow us to delete that class someday soon. Bug: 638435, 914587, 922318 , 922330 Change-Id: I9b72af88009115a55167afa42e7206d54bb5c2c1 Reviewed-on: https://chromium-review.googlesource.com/c/1415312 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#624035} [delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/end.js [modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/manifest.json [delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/start.js [modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/test.js [modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/renderer/bindings/core/v8/script_controller.cc [modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/renderer/core/dom/document.cc [modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/renderer/core/dom/document.h [modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/renderer/core/exported/web_view_test.cc [modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/renderer/core/html/forms/html_form_element.cc [modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/renderer/core/html/html_frame_owner_element.cc [modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/renderer/core/html/lazy_load_frame_observer_test.cc [modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/renderer/core/loader/frame_loader.cc [modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/renderer/core/loader/navigation_scheduler.cc [modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/TestExpectations [modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/editing/inserting/insert-with-javascript-protocol-crash-expected.txt [delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/external/wpt/dom/nodes/Document-contentType/contentType/contenttype_javascripturi-expected.txt [delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/navigating-across-documents/013-expected.txt [delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/navigating-across-documents/014-expected.txt [delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/navigating-across-documents/015-expected.txt [delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/navigating-across-documents/javascript-url-abort/javascript-url-abort-return-value-string.tentative-expected.txt [delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/029-expected.txt [delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/030-expected.txt [delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/040-expected.txt [delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/080-expected.txt [delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/108-expected.txt [delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/109-expected.txt [modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/dom/Element/id-in-frameset-expected.txt [modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/dom/insertedIntoDocument-iframe.html [delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/fast/dom/javascript-url-crash-function-expected.txt [delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/fast/dom/javascript-url-crash-function.html [delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/fast/dom/javascript-url-exception-isolation-expected.txt [delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/fast/dom/javascript-url-exception-isolation.html [modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/dom/replaced-image-map.html [delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/fast/dom/resources/javascript-url-crash-function-iframe.html [modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/events/access-key-self-destruct.html [modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/events/click-anchor-blur-refocus-window-expected.html [modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/events/click-anchor-refocus-window-expected.html [modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/events/click-svganchor-blur-refocus-window-expected.html [modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/events/click-svganchor-refocus-window-expected.html [modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/events/domactivate-sets-underlying-click-event-as-handled-expected.txt [modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/events/domactivate-sets-underlying-click-event-as-handled.html [modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/forms/formaction-attribute.html [modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/frames/adopt-from-created-document.html [modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/frames/navigation-in-pagehide.html [modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/frames/out-of-document-iframe-has-child-frame.html [modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/loader/detach-iframe-while-loading-javascript-url-expected.txt [modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/loader/detach-iframe-while-loading-javascript-url.html [modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/loader/detach-while-printing-expected.txt [modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/loader/detach-while-printing.html [modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/loader/document-open-iframe-then-detach-expected.txt [modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/loader/document-open-iframe-then-detach.html [modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/parser/xml-error-adopted.xml [modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/replaced/image-map-bug16782.html [modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/replaced/image-map.html [modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/http/tests/navigation/lockedhistory-iframe-expected.txt [modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/http/tests/navigation/lockedhistory-iframe.html [modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-sub-frame.html [modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control.html [modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/http/tests/security/xssAuditor/resources/javascript-link-safe.php [modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/paint/invalidation/scroll/repaint-during-scroll-with-zoom.html
Looks like the reland didn't reintroduce the flake.
Comment 1 by ksakamoto@chromium.org
, Jan 16