New issue
Advanced search Search tips

Issue 922323 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 739863



Sign in to add a comment

telemetry_perf_unittests doesn't respect tools/perf/expectations.config

Project Member Reported by crouleau@chromium.org, Jan 16

Issue description

For example, you can run

./tools/perf/run_tests --test-filter=benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop/load:games:spychase:2018

and it works even if the line

crbug.com/999999 [ All ] system_health.memory_desktop/load:games:spychase:2018 [ Skip ]

is in tools/perf/expectations.config.


However, 
./tools/perf/run_benchmark system_health.memory_desktop --story-filter=load:games:spychase:2018

does skip the test when expectations.config contains the skip line.



I wonder if it is better to fix this or to come up with something totally different instead.



 
Blocking: 739863

Comment 2 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 3 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Tests>Telemetry

Sign in to add a comment