Web UI: Non action-buttons get blue border instead of background on hover |
|||
Issue descriptionChrome Version: 73.0.3672.0 Canary OS: Win10, also reproduces on Linux on ToT, have not tried others Steps to reproduce: (1) Open Print Preview (2) Hover mouse on "Cancel" button in header Expected: Light blue background appears Actual: Blue border appears Same on other white (non action-button) paper-buttons in Print Preview, and also reproduces on other Web UI pages, e.g. "Turn off" sync button and "Change" downloads location button in settings. Okay on 73.0.3664.3 Dev. Bisects to https://chromium.googlesource.com/chromium/src/+log/9afafd8fa37175cd36bf01c8f272c39a75d2e1f8..c77fae33781b6c45947bc22e114a76c69f677924
,
Jan 16
additional problem: CSS parsers don't like when you omit semi-colons (;). they get all grouchy. also, I meant to use GM2 Google Blue 100, not Material Design Blue 100. doh.
,
Jan 16
(6 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ada0422f321ef4a5325c51325c267f989460e083 commit ada0422f321ef4a5325c51325c267f989460e083 Author: Dan Beam <dbeam@chromium.org> Date: Wed Jan 16 08:22:44 2019 Fix secondary button :hover border color (for all buttons) R=rbpotter@chromium.org BUG= 922314 Change-Id: I6118537750bcd917ad1918badb38eafd7f4797f1 Reviewed-on: https://chromium-review.googlesource.com/c/1414077 Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#623155} [modify] https://crrev.com/ada0422f321ef4a5325c51325c267f989460e083/ui/webui/resources/cr_elements/paper_button_style_css.html [modify] https://crrev.com/ada0422f321ef4a5325c51325c267f989460e083/ui/webui/resources/cr_elements/shared_vars_css.html
,
Jan 16
(6 days ago)
|
|||
►
Sign in to add a comment |
|||
Comment 1 by dbeam@chromium.org
, Jan 16Owner: dbeam@chromium.org
in that CL I changed: paper-button.action-button:hover to paper-button:not([raised]).action-button:hover ^^^^^^^^^^^^^^ so the rules in that block would actually have an effect. i think this was good, but let's see if anybody gets mad.